yaooqinn commented on a change in pull request #1892:
URL: https://github.com/apache/incubator-kyuubi/pull/1892#discussion_r805576043
##########
File path:
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala
##########
@@ -45,8 +47,20 @@ class KyuubiSessionImpl(
extends AbstractSession(protocol, user, password, ipAddress, conf,
sessionManager) {
override val handle: SessionHandle = SessionHandle(protocol)
+ private[kyuubi] val optimizedConf: Map[String, String] = {
+ val confOverlay = sessionManager.sessionConfAdvisor.getConfOverlay(
+ user,
+ normalizedConf.asJava)
+ if (confOverlay != null) {
+ normalizedConf ++ confOverlay.asScala
+ } else {
+ warn(s"the server plugin return null value for user: $user, ignore it")
+ normalizedConf
+ }
+ }
+
// TODO: needs improve the hardcode
- normalizedConf.foreach {
+ optimizedConf.foreach {
Review comment:
we shall also update it at L107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
