yanghua commented on a change in pull request #1891:
URL: https://github.com/apache/incubator-kyuubi/pull/1891#discussion_r805628247
##########
File path:
externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/operation/ExecuteStatement.scala
##########
@@ -107,10 +105,13 @@ class ExecuteStatement(
val operation = executor.parseStatement(sessionId, statement)
operation match {
case queryOperation: QueryOperation =>
runQueryOperation(queryOperation)
- case setOperation: SetOperation => runSetOperation(setOperation)
- case resetOperation: ResetOperation =>
runResetOperation(resetOperation)
+ case setOperation: SetOperation =>
Review comment:
You have supported these two operations in `PlanOnlyStatement `, right?
Maybe here, we can throw an exception then guide users to use
`PlanOnlyStatement`, and make the `ExecuteStatement` operation, only support
DML and DDL? I am not sure if we need to provide two entry points for this
ability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
