jiwq commented on a change in pull request #1907:
URL: https://github.com/apache/incubator-kyuubi/pull/1907#discussion_r805951238
##########
File path: kyuubi-common/src/main/resources/log4j2-defaults.properties
##########
@@ -29,7 +29,7 @@ appender.console.layout.pattern = %d{HH:mm:ss.SSS} %p %c: %m%n
appender.console.filter.1.type = Filters
appender.console.filter.1.a.type = ThresholdFilter
-appender.console.filter.1.a.level = fatal
+appender.console.filter.1.a.level = INFO
Review comment:
Agree to @link3280 . If need change, should better modify global.
##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/Logging.scala
##########
@@ -179,4 +178,20 @@ object Logging {
val binderClass = StaticLoggerBinder.getSingleton.getLoggerFactoryClassStr
"org.apache.logging.slf4j.Log4jLoggerFactory".equals(binderClass)
}
+
+ /**
+ * Return true if log4j2 is initialized by default configuration which has
one
+ * appender with error level. See
`org.apache.logging.log4j.core.config.DefaultConfiguration`.
+ */
+ private def islog4j2DefaultConfigured(): Boolean = {
Review comment:
```suggestion
private def isLog4j2DefaultConfigured(): Boolean = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
