pan3793 commented on a change in pull request #1913:
URL: https://github.com/apache/incubator-kyuubi/pull/1913#discussion_r806730120
##########
File path: docs/integrations/delta_lake_with_azure_blob.md
##########
@@ -106,7 +106,7 @@ Welcome to
____ __
/ __/__ ___ _____/ /__
_\ \/ _ \/ _ `/ __/ '_/
- /___/ .__/\_,_/_/ /_/\_\ version 3.1.2
+ /___/ .__/\_,_/_/ /_/\_\ version 3.2.1
Review comment:
please revert this one, it may makes the context conflict
##########
File path: pom.xml
##########
@@ -132,7 +132,7 @@
<scopt.version>4.0.1</scopt.version>
<slf4j.version>1.7.35</slf4j.version>
<log4j.version>2.17.1</log4j.version>
- <spark.version>3.1.2</spark.version>
+ <spark.version>3.2.1</spark.version>
Review comment:
we should also change `delta.version`, because the minor version of
delta and spark is one-one mapping
##########
File path: pom.xml
##########
@@ -132,7 +132,7 @@
<scopt.version>4.0.1</scopt.version>
<slf4j.version>1.7.35</slf4j.version>
<log4j.version>2.17.1</log4j.version>
- <spark.version>3.1.2</spark.version>
+ <spark.version>3.2.1</spark.version>
Review comment:
we can left some comments here, e.g. 'if change minor version of spark,
don't forget to change the deafult `delta.version`'
##########
File path: pom.xml
##########
@@ -132,7 +132,7 @@
<scopt.version>4.0.1</scopt.version>
<slf4j.version>1.7.35</slf4j.version>
<log4j.version>2.17.1</log4j.version>
- <spark.version>3.1.2</spark.version>
+ <spark.version>3.2.1</spark.version>
Review comment:
we can leave some comments here, e.g. 'if change minor version of spark,
don't forget to change the deafult `delta.version`'
##########
File path: pom.xml
##########
@@ -132,7 +132,7 @@
<scopt.version>4.0.1</scopt.version>
<slf4j.version>1.7.35</slf4j.version>
<log4j.version>2.17.1</log4j.version>
- <spark.version>3.1.2</spark.version>
+ <spark.version>3.2.1</spark.version>
Review comment:
we can leave some comments here, e.g. 'if change the minor version of
spark, don't forget to change the deafult `delta.version`'
##########
File path: docs/integrations/delta_lake_with_azure_blob.md
##########
@@ -106,7 +106,7 @@ Welcome to
____ __
/ __/__ ___ _____/ /__
_\ \/ _ \/ _ `/ __/ '_/
- /___/ .__/\_,_/_/ /_/\_\ version 3.1.2
+ /___/ .__/\_,_/_/ /_/\_\ version 3.2.1
Review comment:
please revert this one, it may makes the context inconsistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
