SteNicholas commented on a change in pull request #1946:
URL: https://github.com/apache/incubator-kyuubi/pull/1946#discussion_r810754787
##########
File path:
kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiConnection.java
##########
@@ -937,6 +943,18 @@ public void close() throws SQLException {
}
}
+ private void closeOnLaunchEngineFailure() throws SQLException {
+ if (engineLogThread != null && engineLogThread.isAlive()) {
+ engineLogThread.interrupt();
+ try {
+ engineLogThread.join(DEFAULT_ENGINE_LOG_THREAD_TIMEOUT);
+ } catch (Exception e) {
+ }
+ engineLogThread = null;
Review comment:
Does this need to consider the condition that the `engineLogThread` is
not null and not alive?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
