pan3793 edited a comment on pull request #1953: URL: https://github.com/apache/incubator-kyuubi/pull/1953#issuecomment-1048481112
Summary of this PR, 1. Upgrade `libthrift` to 0.16.0 due to CVE issues and the coming upstream change of Spark 2. Shade and relocate `thrift` and `hive-service-rpc` classes in `kyuubi-spark-engine`, it's necessary to avoding conflict with old thrift libs bundled in Spark binary releases. 3. Due to thrift change the method signature, the subclasses of Kyuubi also need to change to pass compile. 4. We rely on Hive 2.3.9 jars in some components, e.g. `kyuubi-hive-jdbc`, `LocalMetaServer` in `kyuubi-server` test classes. Some classes in Hive jars compiled against old thrift interfaces which are not compatible with thrift 0.16.0, it causes runtime link error, we found all broken tests and copy the broken classes with necessary modification to make it work with thrift 0.16.0, but there may still risk somewhere the UT not covered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
