pan3793 commented on a change in pull request #1980:
URL: https://github.com/apache/incubator-kyuubi/pull/1980#discussion_r815984847
##########
File path:
kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala
##########
@@ -66,12 +66,12 @@ abstract class TFrontendService(name: String)
protected def stopServer(): Unit
override def stop(): Unit = synchronized {
+ super.stop()
Review comment:
> Generally, the order of super.start() and super.stop() should be
symmetrical
What I mean **symmetrical** is, normally the pattern should be one of
```
def start(): Unit = {
super.start()
self.start()
}
def stop(): Unit = {
self.stop()
super.stop()
}
```
```
def start(): Unit = {
self.start()
super.start()
}
def stop(): Unit = {
super.stop()
self.stop()
}
```
I'm just surprised that you changed it to
```
def start(): Unit = {
self.start()
super.start()
}
def stop(): Unit = {
self.stop()
super.stop()
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
