SteNicholas commented on a change in pull request #1981:
URL: https://github.com/apache/incubator-kyuubi/pull/1981#discussion_r816381467
##########
File path: kyuubi-metrics/pom.xml
##########
@@ -88,6 +88,11 @@
<artifactId>jackson-databind</artifactId>
</dependency>
+ <dependency>
Review comment:
> it is only used at Kyuubi Server, so there is no other version of guava
@ulysses-you, no matter whether the guava package is only used at Kyuubi
Server, the guava package is better to be shaded for the users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
