pan3793 commented on a change in pull request #1973:
URL: https://github.com/apache/incubator-kyuubi/pull/1973#discussion_r816388059
##########
File path: externals/kyuubi-flink-sql-engine/bin/flink-sql-engine.sh
##########
@@ -37,31 +37,26 @@ FLINK_SQL_ENGINE_HOME="$(cd `dirname $0`/..; pwd)"
if [[ "$FLINK_SQL_ENGINE_HOME" == "$KYUUBI_HOME/externals/engines/flink" ]];
then
FLINK_SQL_ENGINE_LIB_DIR="$FLINK_SQL_ENGINE_HOME/lib"
FLINK_SQL_ENGINE_JAR=$(find "$FLINK_SQL_ENGINE_LIB_DIR" -regex
".*/kyuubi-flink-sql-engine_.*\.jar")
- FLINK_HADOOP_CLASSPATH="$INTERNAL_HADOOP_CLASSPATHS"
Review comment:
Do we need this one? What if user provides the hadoop jar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
