pan3793 commented on a change in pull request #1973:
URL: https://github.com/apache/incubator-kyuubi/pull/1973#discussion_r816535168
##########
File path: externals/kyuubi-flink-sql-engine/bin/flink-sql-engine.sh
##########
@@ -52,16 +52,14 @@ else
logback_conf_file="unused.xml"
fi
-FULL_CLASSPATH="$FLINK_SQL_ENGINE_JAR:$FLINK_SQL_CLIENT_JAR:$CC_CLASSPATH:$FLINK_HADOOP_CLASSPATH"
Review comment:
And also, I don't think the change of this script proves the flink sql
engine can run without hadoop.
We should pick the Hadoop jars in production if user provides it, but we
should not include `hadoop-client-*` jars in UT, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
