wForget commented on a change in pull request #1995:
URL: https://github.com/apache/incubator-kyuubi/pull/1995#discussion_r818253224
##########
File path:
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala
##########
@@ -71,41 +71,48 @@ case class SparkSQLEngine(spark: SparkSession) extends
Serverable("SparkSQLEngin
object SparkSQLEngine extends Logging {
- val sparkConf: SparkConf = new SparkConf()
+ private var _sparkConf: SparkConf = _
- val kyuubiConf: KyuubiConf = KyuubiConf()
+ private var _kyuubiConf: KyuubiConf = _
+
+ def kyuubiConf: KyuubiConf = _kyuubiConf
var currentEngine: Option[SparkSQLEngine] = None
- private val user = currentUser
+ private lazy val user = currentUser
private val countDownLatch = new CountDownLatch(1)
+ SignalRegister.registerLogger(logger)
+ setupConf()
Review comment:
Should the `SparkSQLEngine.setupConf()` call in
`WithSparkSQLEngine#startSparkEngine` be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
