This is an automated email from the ASF dual-hosted git repository.
yao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new 48c0059 [KYUUBI #2127] avoid to set HA_ZK_NAMESPACE and
HA_ZK_ENGINE_REF_ID repetitively when create flink sql engine
48c0059 is described below
commit 48c0059def15a722306e5f9f9e4911f7599f8502
Author: Min Zhao <[email protected]>
AuthorDate: Mon Mar 14 10:11:52 2022 +0800
[KYUUBI #2127] avoid to set HA_ZK_NAMESPACE and HA_ZK_ENGINE_REF_ID
repetitively when create flink sql engine
### _Why are the changes needed?_
The HA_ZK_NAMESPACE and HA_ZK_ENGINE_REF_ID are set repetitively when
create flink sql engine.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including
negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run
test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests)
locally before make a pull request
Closes #2128 from zhaomin1423/fix_set_conf.
Closes #2127
402f2f11 [Min Zhao] [KYUUBI #2127] avoid to set HA_ZK_NAMESPACE and
HA_ZK_ENGINE_REF_ID repetitively when create flink sql engine
Authored-by: Min Zhao <[email protected]>
Signed-off-by: Kent Yao <[email protected]>
---
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala | 2 --
1 file changed, 2 deletions(-)
diff --git
a/kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala
b/kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala
index 21a8a89..65133fb 100644
--- a/kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala
+++ b/kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala
@@ -195,8 +195,6 @@ private[kyuubi] class EngineRef(
conf.set(
FlinkProcessBuilder.TAG_KEY,
conf.getOption(FlinkProcessBuilder.TAG_KEY).map(_ +
",").getOrElse("") + "KYUUBI")
- conf.set(HA_ZK_NAMESPACE, engineSpace)
- conf.set(HA_ZK_ENGINE_REF_ID, engineRefId)
new FlinkProcessBuilder(appUser, conf, extraEngineLog)
case TRINO =>
new TrinoProcessBuilder(appUser, conf, extraEngineLog)
