This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new 0875ce706 [KYUUBI #4784] Use nodejs v18 in CI builds and maven web-ui
builds
0875ce706 is described below
commit 0875ce70664880d4e065897c2807eb0798a62557
Author: liangbowen <[email protected]>
AuthorDate: Wed May 3 18:42:23 2023 +0800
[KYUUBI #4784] Use nodejs v18 in CI builds and maven web-ui builds
### _Why are the changes needed?_
- nodejs v18 is the current active LTS version of nodejs since October
2022, while v16 is in maintenance mode and no longer in the active status
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including
negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run
test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests)
locally before make a pull request
This patch had conflicts when merged, resolved by
Committer: Cheng Pan <[email protected]>
Closes #4784 from bowenliang123/nodejs18.
Closes #4784
483c3ac56 [liangbowen] use nodejs v18 in ci builds and maven builds
Authored-by: liangbowen <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
---
.github/workflows/style.yml | 2 +-
.github/workflows/web-ui.yml | 2 +-
pom.xml | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/.github/workflows/style.yml b/.github/workflows/style.yml
index e2e6fd70e..479b74e36 100644
--- a/.github/workflows/style.yml
+++ b/.github/workflows/style.yml
@@ -89,7 +89,7 @@ jobs:
- name: setup npm
uses: actions/setup-node@v3
with:
- node-version: 16
+ node-version: 18
- name: Web UI Style with node
run: |
cd ./kyuubi-server/web-ui
diff --git a/.github/workflows/web-ui.yml b/.github/workflows/web-ui.yml
index 65fb47594..13d072321 100644
--- a/.github/workflows/web-ui.yml
+++ b/.github/workflows/web-ui.yml
@@ -24,7 +24,7 @@ jobs:
- name: setup npm
uses: actions/setup-node@v3
with:
- node-version: 16
+ node-version: 18
- name: npm run coverage & build
run: |
cd ./kyuubi-server/web-ui
diff --git a/pom.xml b/pom.xml
index 4ce11caf5..af56eb167 100644
--- a/pom.xml
+++ b/pom.xml
@@ -206,7 +206,7 @@
<!-- webui -->
<webui.skip>true</webui.skip>
- <node.version>v16.19.1</node.version>
+ <node.version>v18.16.0</node.version>
<pnpm.version>v8.4.0</pnpm.version>
<!-- apply to kyuubi-hive-jdbc/kyuubi-hive-beeline module -->
