[kyuubi] branch master updated: [KYUUBI #5035] Spark engine session page display session end time and duration

[bowenliang]

This is an automated email from the ASF dual-hosted git repository.

bowenliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new 84748fce1 [KYUUBI #5035] Spark engine session page display session end 
time and duration
84748fce1 is described below

commit 84748fce1168d6689154c9b9cf138c78dfc9b687
Author: senmiaoliu <senmiao...@trip.com>
AuthorDate: Wed Jul 12 11:23:13 2023 +0800

    [KYUUBI #5035] Spark engine session page display session end time and 
duration
    
    ### _Why are the changes needed?_
    close #5035
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including 
negative and positive cases if possible
    
    - [x] Add screenshots for manual tests if appropriate
    
![image](https://github.com/apache/kyuubi/assets/18713676/502b489f-6cbd-4510-a89c-b7816b3e15bf)
    - [x] [Run 
test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests)
 locally before make a pull request
    
    Closes #5038 from lsm1/features/kyuubi_5035.
    
    Closes #5035
    
    9ee06f113 [senmiaoliu] fix style
    c68fd65ab [senmiaoliu] fix style
    5d3d86972 [senmiaoliu] show session end time
    
    Authored-by: senmiaoliu <senmiao...@trip.com>
    Signed-off-by: liangbowen <liangbo...@gf.com.cn>
---
 .../main/scala/org/apache/spark/ui/EngineSessionPage.scala   | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git 
a/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/EngineSessionPage.scala
 
b/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/EngineSessionPage.scala
index 8ae830a84..cdfc6d313 100644
--- 
a/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/EngineSessionPage.scala
+++ 
b/externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/ui/EngineSessionPage.scala
@@ -78,8 +78,18 @@ case class EngineSessionPage(parent: EngineTab)
         <h4>
           User {sessionStat.username},
           IP {sessionStat.ip},
-          Server {sessionStat.serverIp},
+          Server {sessionStat.serverIp}
+        </h4> ++
+        <h4>
           Session created at {formatDate(sessionStat.startTime)},
+          {
+          if (sessionStat.endTime > 0) {
+            s"""
+               | ended at ${formatDate(sessionStat.endTime)},
+               | after ${formatDuration(sessionStat.duration)}.
+               |""".stripMargin
+          }
+        }
           Total run {sessionStat.totalOperations} SQL
         </h4> ++
         sessionPropertiesTable ++