This is an automated email from the ASF dual-hosted git repository.
paullin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new 1d5a5c80c [KYUUBI #5106][Flink] Improve logs for fatal errors
1d5a5c80c is described below
commit 1d5a5c80c7bd30754ed670917210f30adcf365e4
Author: Paul Lin <[email protected]>
AuthorDate: Mon Jul 31 17:49:12 2023 +0800
[KYUUBI #5106][Flink] Improve logs for fatal errors
### _Why are the changes needed?_
As titled.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including
negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run
test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests)
locally before make a pull request
Closes #5107 from link3280/engine_fatal_log.
Closes #5106
db45392d1 [Paul Lin] [KYUUBI #5106][Flink] Improve logs for fatal errors
Authored-by: Paul Lin <[email protected]>
Signed-off-by: Paul Lin <[email protected]>
---
.../src/main/scala/org/apache/kyuubi/engine/flink/FlinkSQLEngine.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/FlinkSQLEngine.scala
b/externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/FlinkSQLEngine.scala
index 99a9ee56b..10ef9991f 100644
---
a/externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/FlinkSQLEngine.scala
+++
b/externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/FlinkSQLEngine.scala
@@ -109,8 +109,8 @@ object FlinkSQLEngine extends Logging {
countDownLatch.await()
} catch {
case t: Throwable if currentEngine.isDefined =>
+ error("Fatal error occurs, thus stopping the engines", t)
currentEngine.foreach { engine =>
- error(t)
engine.stop()
}
case t: Throwable =>
