This is an automated email from the ASF dual-hosted git repository.
bowenliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new a01d7092e [KYUUBI #5222] [FLINK] Remove unused provided dependencies
in Flink SQL engine
a01d7092e is described below
commit a01d7092eaacbbf1dbb11d421ba3746073b5b586
Author: liangbowen <[email protected]>
AuthorDate: Thu Aug 31 11:05:11 2023 +0800
[KYUUBI #5222] [FLINK] Remove unused provided dependencies in Flink SQL
engine
### _Why are the changes needed?_
- Remove the provided dependency
`flink-table-planner_${scala.binary.version}` which provides a legacy table
planner API on Scala, but is never used in Kyuubi's source code or in runtime
directly.
- `** The legacy planner is deprecated and will be dropped in Flink
1.14.**` according to [Flink 1.13's doc of Legacy
Planner](https://nightlies.apache.org/flink/flink-docs-release-1.13/docs/dev/table/legacy_planner/)
- Kyuubi has dropped support for Flink 1.14 and before in #4588
- Remove the unused provided dependency `flink-sql-parser`
- All tests on Scala 2.12 work fine without them, as `flink-table-runtime`
dependency provides enough Java API for usage.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including
negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run
test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests)
locally before make a pull request
### _Was this patch authored or co-authored using generative AI tooling?_
No.
Closes #5222 from bowenliang123/flink-remove-planner.
Closes #5222
716ec06e9 [liangbowen] remove flink-sql-parser dependency
0922ba5af [liangbowen] Remove unnecessary dependency flink-table-planner
Authored-by: liangbowen <[email protected]>
Signed-off-by: Bowen Liang <[email protected]>
---
externals/kyuubi-flink-sql-engine/pom.xml | 12 ------------
pom.xml | 12 ------------
2 files changed, 24 deletions(-)
diff --git a/externals/kyuubi-flink-sql-engine/pom.xml
b/externals/kyuubi-flink-sql-engine/pom.xml
index d485e012b..bf9e100d0 100644
--- a/externals/kyuubi-flink-sql-engine/pom.xml
+++ b/externals/kyuubi-flink-sql-engine/pom.xml
@@ -99,24 +99,12 @@
<scope>provided</scope>
</dependency>
- <dependency>
- <groupId>org.apache.flink</groupId>
-
<artifactId>flink-table-planner_${scala.binary.version}</artifactId>
- <scope>provided</scope>
- </dependency>
-
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-table-runtime</artifactId>
<scope>provided</scope>
</dependency>
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-sql-parser</artifactId>
- <scope>provided</scope>
- </dependency>
-
<!-- tests -->
<dependency>
<groupId>org.apache.kyuubi</groupId>
diff --git a/pom.xml b/pom.xml
index 99e17ce96..9ded97e99 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1391,12 +1391,6 @@
<version>${flink.version}</version>
</dependency>
- <dependency>
- <groupId>org.apache.flink</groupId>
-
<artifactId>flink-table-planner_${scala.binary.version}</artifactId>
- <version>${flink.version}</version>
- </dependency>
-
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-table-runtime</artifactId>
@@ -1404,12 +1398,6 @@
<scope>provided</scope>
</dependency>
- <dependency>
- <groupId>org.apache.flink</groupId>
- <artifactId>flink-sql-parser</artifactId>
- <version>${flink.version}</version>
- </dependency>
-
<dependency>
<groupId>org.apache.flink</groupId>
<artifactId>flink-sql-client</artifactId>
