This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch branch-1.8
in repository https://gitbox.apache.org/repos/asf/kyuubi.git
The following commit(s) were added to refs/heads/branch-1.8 by this push:
new d99e3c7d5 [KYUUBI #5318] Pin maven-source-plugin 3.2.1
d99e3c7d5 is described below
commit d99e3c7d5c2c3f2c016a7b72c57919a07a0dc3b3
Author: Cheng Pan <[email protected]>
AuthorDate: Thu Sep 21 09:49:59 2023 +0800
[KYUUBI #5318] Pin maven-source-plugin 3.2.1
### _Why are the changes needed?_
The current maven-source-plugin version(3.3.0) inherits from
`org.apache:parent:pom:30`, unfortunately, MSOURCES-121 breaks shaded modules
to create source artifacts.
```
[ERROR] We have duplicated artifacts attached.
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork (attach-sources)
on project kyuubi-hive-jdbc-shaded: Presumably you have configured
maven-source-plugn to execute twice times in your build. You have to configure
a classifier for at least on of them. -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
goal org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork
(attach-sources) on project kyuubi-hive-jdbc-shaded: Presumably you have
configured maven-source-plugn to execute twice times in your build. You have to
configure a classifier for at least on of them.
```
We should skip upgrading until MSOURCES-141 gets fixed.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including
negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run
test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests)
locally before make a pull request
### _Was this patch authored or co-authored using generative AI tooling?_
No.
Closes #5318 from pan3793/mvn-source.
Closes #5318
7d12d12e3 [Cheng Pan] [KYUUBI #5318] Pin maven-source-plugin 3.2.1
Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit 83bbefe847c04d163c6a62569c9a038b867c7eaa)
Signed-off-by: Cheng Pan <[email protected]>
---
pom.xml | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/pom.xml b/pom.xml
index 402cf5a8d..252a3b86e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -241,6 +241,9 @@
<maven.plugin.scalastyle.version>1.0.0</maven.plugin.scalastyle.version>
<maven.plugin.shade.version>3.4.1</maven.plugin.shade.version>
<maven.plugin.silencer.version>1.7.13</maven.plugin.silencer.version>
+ <!-- MSOURCES-121 breaks creating source artifacts for shaded modules,
+ we should skip upgrading until MSOURCES-141 gets fixed. -->
+ <maven.plugin.source.version>3.2.1</maven.plugin.source.version>
<maven.scaladoc.skip>false</maven.scaladoc.skip>
<maven.scalastyle.skip>false</maven.scalastyle.skip>
@@ -1755,6 +1758,12 @@
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-source-plugin</artifactId>
+ <version>${maven.plugin.source.version}</version>
+ </plugin>
+
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
