(kyuubi) branch master updated: [KYUUBI #5716] [TEST] Fix match may not be exhaustive in Scala 2.13

[csy]

This is an automated email from the ASF dual-hosted git repository.

csy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new 019bd50b9 [KYUUBI #5716] [TEST] Fix match may not be exhaustive in 
Scala 2.13
019bd50b9 is described below

commit 019bd50b99e99cbbf61009ff725cb901ca82ed26
Author: sychen <syc...@ctrip.com>
AuthorDate: Fri Nov 17 18:06:13 2023 +0800

    [KYUUBI #5716] [TEST] Fix match may not be exhaustive in Scala 2.13
    
    # :mag: Description
    ## Issue References 🔗
    
    https://github.com/apache/kyuubi/actions/runs/6885433363/job/18729567019
    ```
    Error: ] 
/home/runner/work/kyuubi/kyuubi/extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/serde/tableExtractors.scala:259:
 match may not be exhaustive.
    It would fail on the following inputs: SubqueryAlias(_, (x: 
org.apache.spark.sql.catalyst.plans.logical.LogicalPlan forSome x not in 
org.apache.spark.sql.catalyst.plans.logical.SubqueryAlias)), SubqueryAlias(_, 
SubqueryAlias(_, _))
    ```
    
    ## Describe Your Solution 🔧
    
    Please include a summary of the change and which issue is fixed. Please 
also include relevant motivation and context. List any dependencies that are 
required for this change.
    
    ## Types of changes :bookmark:
    
    - [x] Bugfix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
    
    ## Test Plan 🧪
    
    #### Behavior Without This Pull Request :coffin:
    
    #### Behavior With This Pull Request :tada:
    
    #### Related Unit Tests
    
    ---
    
    # Checklists
    ## 📝 Author Self Checklist
    
    - [ ] My code follows the [style 
guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html)
 of this project
    - [ ] I have performed a self-review
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] My changes generate no new warnings
    - [ ] I have added tests that prove my fix is effective or that my feature 
works
    - [ ] New and existing unit tests pass locally with my changes
    - [ ] This patch was not authored or co-authored using [Generative 
Tooling](https://www.apache.org/legal/generative-tooling.html)
    
    ## 📝 Committer Pre-Merge Checklist
    
    - [x] Pull request title is okay.
    - [x] No license issues.
    - [ ] Milestone correctly set?
    - [ ] Test coverage is ok
    - [x] Assignees are selected.
    - [x] Minimum number of approvals
    - [x] No changes are requested
    
    **Be nice. Be informative.**
    
    Closes #5716 from cxzl25/fix_scala_2.13.
    
    Closes #5716
    
    5c761a812 [sychen] match may not be exhaustive
    
    Authored-by: sychen <syc...@ctrip.com>
    Signed-off-by: Shaoyun Chen <c...@apache.org>
---
 .../org/apache/kyuubi/plugin/spark/authz/serde/tableExtractors.scala   | 3 +++
 1 file changed, 3 insertions(+)

diff --git 
a/extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/serde/tableExtractors.scala
 
b/extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/serde/tableExtractors.scala
index 678175675..890b36959 100644
--- 
a/extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/serde/tableExtractors.scala
+++ 
b/extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/serde/tableExtractors.scala
@@ -262,6 +262,7 @@ class SubqueryAliasTableExtractor extends TableExtractor {
         lookupExtractor[StringTableExtractor].apply(spark, 
identifier.toString())
       case SubqueryAlias(identifier, _) if !isPathIdentifier(identifier.name, 
spark) =>
         lookupExtractor[StringTableExtractor].apply(spark, 
identifier.toString())
+      case _ => None
     }
   }
 }
@@ -285,6 +286,7 @@ class HudiDataSourceV2RelationTableExtractor extends 
TableExtractor {
       // Match multipartIdentifier without tableAlias
       case SubqueryAlias(identifier, _) =>
         lookupExtractor[StringTableExtractor].apply(spark, 
identifier.toString())
+      case _ => None
     }
   }
 }
@@ -298,6 +300,7 @@ class HudiMergeIntoTargetTableExtractor extends 
TableExtractor {
       // Match multipartIdentifier without tableAlias
       case SubqueryAlias(identifier, _) =>
         lookupExtractor[StringTableExtractor].apply(spark, 
identifier.toString())
+      case _ => None
     }
   }
 }