This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch branch-1.8
in repository https://gitbox.apache.org/repos/asf/kyuubi.git
The following commit(s) were added to refs/heads/branch-1.8 by this push:
new eb6c32466 [KYUUBI #5737] [DOC] Correct JDBC URL demo in Flink docs
eb6c32466 is described below
commit eb6c32466e45a77ebd66859e6f490e86e9b65ea9
Author: Yuwei Zhan <[email protected]>
AuthorDate: Tue Nov 21 21:56:07 2023 +0800
[KYUUBI #5737] [DOC] Correct JDBC URL demo in Flink docs
# :mag: Description
flink setting need additional prefix flink. to override settings
## Issue References ๐
This pull request fixes #5737
## Describe Your Solution ๐ง
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that are
required for this change.
## Types of changes :bookmark:
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
## Test Plan ๐งช
#### Behavior Without This Pull Request :coffin:
#### Behavior With This Pull Request :tada:
#### Related Unit Tests
---
# Checklists
## ๐ Author Self Checklist
- [ ] My code follows the [style
guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html)
of this project
- [ ] I have performed a self-review
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature
works
- [ ] New and existing unit tests pass locally with my changes
- [ ] This patch was not authored or co-authored using [Generative
Tooling](https://www.apache.org/legal/generative-tooling.html)
## ๐ Committer Pre-Merge Checklist
- [x] Pull request title is okay.
- [x] No license issues.
- [x] Milestone correctly set?
- [ ] Test coverage is ok
- [x] Assignees are selected.
- [x] Minimum number of approvals
- [x] No changes are requested
**Be nice. Be informative.**
Closes #5745 from dik111/update-doc.
Closes #5737
27ac6c1db [yuwei zhan] Update AllKyuubiConfiguration about flink jdbc url
a1b1b2cba [yuwei zhan] Update settings.md
Lead-authored-by: Yuwei Zhan <[email protected]>
Co-authored-by: yuwei zhan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit 931b5026e797d705f545be41941af7240e4534e3)
Signed-off-by: Cheng Pan <[email protected]>
---
docs/configuration/settings.md | 2 +-
.../test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/configuration/settings.md b/docs/configuration/settings.md
index 1a423d67b..a904c8bcb 100644
--- a/docs/configuration/settings.md
+++ b/docs/configuration/settings.md
@@ -532,7 +532,7 @@ The below options in `kyuubi-defaults.conf` will set
`parallelism.default: 2` an
### Via JDBC Connection URL
-Setting them in the JDBC Connection URL supplies session-specific for each SQL
engine. For example:
```jdbc:hive2://localhost:10009/default;#parallelism.default=2;taskmanager.memory.process.size=5g```
+Setting them in the JDBC Connection URL supplies session-specific for each SQL
engine. For example:
```jdbc:hive2://localhost:10009/default;#flink.parallelism.default=2;flink.taskmanager.memory.process.size=5g```
### Via SET Statements
diff --git
a/kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
b/kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
index 8c0806ba3..7cb4c9002 100644
---
a/kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
+++
b/kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
@@ -171,7 +171,7 @@ class AllKyuubiConfiguration extends KyuubiFunSuite {
"### Via JDBC Connection URL" +=
"""Setting them in the JDBC Connection URL supplies session-specific
| for each SQL engine. For example:
```jdbc:hive2://localhost:10009/default;
- |#parallelism.default=2;taskmanager.memory.process.size=5g```
+
|#flink.parallelism.default=2;flink.taskmanager.memory.process.size=5g```
|""" +=
"### Via SET Statements" +=
"""Please refer to the Flink official online documentation for [SET
Statements]
