This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new 65ba3b1d6 [KYUUBI #5777] Include `hive-service-rpc` in Hive engine jar
65ba3b1d6 is described below

commit 65ba3b1d63e03925f0260159bb01bcbc40202c7a
Author: zhouyifan279 <[email protected]>
AuthorDate: Mon Nov 27 14:02:05 2023 +0800

    [KYUUBI #5777] Include `hive-service-rpc` in Hive engine jar
    
    # :mag: Description
    ## Issue References ๐Ÿ”—
    
    Exception was thrown when execute SQL on HiveSQLEngine when HIVE_HOME set 
to Hive 2.1.1-cdh6.3.2.
    
![image](https://github.com/apache/kyuubi/assets/88070094/79c397f5-8bc2-4f40-b617-94cbf7bbf86f)
    
    ## Describe Your Solution ๐Ÿ”ง
    hive-service-rpc-2.1.1-cdh6.3.2.jar is not compatible with Kyuubi Server's 
hive-service-rpc.
    We should use Kyuubi Server's hive-service-rpc at HiveSQLEngine side.
    
    ## Types of changes :bookmark:
    
    - [x] Bugfix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
    
    ## Test Plan ๐Ÿงช
    
    #### Behavior Without This Pull Request :coffin:
    
    Exception was thrown
    
![image](https://github.com/apache/kyuubi/assets/88070094/79c397f5-8bc2-4f40-b617-94cbf7bbf86f)
    
    #### Behavior With This Pull Request :tada:
    SQL execute successfully
    <img width="1545" alt="image" 
src="https://github.com/apache/kyuubi/assets/88070094/8bb7cfa0-0af0-42cf-acf5-40cff39efd1f";>
    
    #### Related Unit Tests
    
    ---
    
    # Checklists
    ## ๐Ÿ“ Author Self Checklist
    
    - [x] My code follows the [style 
guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html)
 of this project
    - [x] I have performed a self-review
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [x] My changes generate no new warnings
    - [ ] I have added tests that prove my fix is effective or that my feature 
works
    - [ ] New and existing unit tests pass locally with my changes
    - [x] This patch was not authored or co-authored using [Generative 
Tooling](https://www.apache.org/legal/generative-tooling.html)
    
    ## ๐Ÿ“ Committer Pre-Merge Checklist
    
    - [x] Pull request title is okay.
    - [x] No license issues.
    - [x] Milestone correctly set?
    - [ ] Test coverage is ok
    - [x] Assignees are selected.
    - [x] Minimum number of approvals
    - [x] No changes are requested
    
    **Be nice. Be informative.**
    
    Closes #5777 from zhouyifan279/hive-sql-engine.
    
    Closes #5777
    
    c55903a52 [zhouyifan279] Include org.apache.hive:hive-service-rpc in 
HiveSQLEngine jar
    
    Authored-by: zhouyifan279 <[email protected]>
    Signed-off-by: Cheng Pan <[email protected]>
---
 externals/kyuubi-hive-sql-engine/pom.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/externals/kyuubi-hive-sql-engine/pom.xml 
b/externals/kyuubi-hive-sql-engine/pom.xml
index 89f2395f0..ad7a76763 100644
--- a/externals/kyuubi-hive-sql-engine/pom.xml
+++ b/externals/kyuubi-hive-sql-engine/pom.xml
@@ -167,6 +167,7 @@
                             
<include>com.fasterxml.jackson.core:jackson-core</include>
                             
<include>com.fasterxml.jackson.core:jackson-databind</include>
                             
<include>com.fasterxml.jackson.module:jackson-module-scala_${scala.binary.version}</include>
+                            <include>org.apache.hive:hive-service-rpc</include>
                             <include>org.apache.kyuubi:*</include>
                         </includes>
                     </artifactSet>

Reply via email to