This is an automated email from the ASF dual-hosted git repository.
bowenliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new 0adb7d1b4 [KYUUBI #5842] [BUILD] Bump actions/setup-node from v3 to v4
0adb7d1b4 is described below
commit 0adb7d1b4f66cebb5d8c4dba93193b8ef02cbec8
Author: Bowen Liang <[email protected]>
AuthorDate: Sat Dec 9 23:32:26 2023 +0800
[KYUUBI #5842] [BUILD] Bump actions/setup-node from v3 to v4
# :mag: Description
## Issue References ๐
This pull request fixes #
## Describe Your Solution ๐ง
- `setup-node` Github Action v4 release note:
https://github.com/actions/setup-node/releases/tag/v4.0.0. Update node version
runtime for the actions from node16 to node20.
## Types of changes :bookmark:
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
## Test Plan ๐งช
#### Behavior Without This Pull Request :coffin:
#### Behavior With This Pull Request :tada:
#### Related Unit Tests
---
# Checklists
## ๐ Author Self Checklist
- [x] My code follows the [style
guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html)
of this project
- [x] I have performed a self-review
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature
works
- [ ] New and existing unit tests pass locally with my changes
- [x] This patch was not authored or co-authored using [Generative
Tooling](https://www.apache.org/legal/generative-tooling.html)
## ๐ Committer Pre-Merge Checklist
- [ ] Pull request title is okay.
- [ ] No license issues.
- [ ] Milestone correctly set?
- [ ] Test coverage is ok
- [ ] Assignees are selected.
- [ ] Minimum number of approvals
- [ ] No changes are requested
**Be nice. Be informative.**
Closes #5842 from bowenliang123/actions-node-4.
Closes #5842
8610525a8 [Bowen Liang] Bump actions/setup-node from v3 to v4
Authored-by: Bowen Liang <[email protected]>
Signed-off-by: Bowen Liang <[email protected]>
---
.github/workflows/style.yml | 2 +-
.github/workflows/web-ui.yml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/style.yml b/.github/workflows/style.yml
index de64c22c5..5b8b6a704 100644
--- a/.github/workflows/style.yml
+++ b/.github/workflows/style.yml
@@ -92,7 +92,7 @@ jobs:
pip install black==$SPOTLESS_BLACK_VERSION
build/mvn spotless:check ${{ matrix.profiles }}
-Pspotless-python,spark-3.1
- name: setup npm
- uses: actions/setup-node@v3
+ uses: actions/setup-node@v4
with:
node-version: 18
- name: Web UI Style with node
diff --git a/.github/workflows/web-ui.yml b/.github/workflows/web-ui.yml
index b6b67333f..ec0a88575 100644
--- a/.github/workflows/web-ui.yml
+++ b/.github/workflows/web-ui.yml
@@ -35,7 +35,7 @@ jobs:
echo "NODEJS_VERSION=${NODEJS_VERSION}" >> "$GITHUB_ENV"
echo "PNPM_VERSION=${PNPM_VERSION}" >> "$GITHUB_ENV"
- name: Setup Nodejs and NPM
- uses: actions/setup-node@v3
+ uses: actions/setup-node@v4
with:
node-version: ${{env.NODEJS_VERSION}}
cache: npm
