This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi-shaded.git


The following commit(s) were added to refs/heads/master by this push:
     new 78570a0  [KYUUBI-SHADED #31] Move transitve deps of Zookeeper/Curator 
to sub-package
78570a0 is described below

commit 78570a09513d6f7922152fbed3cb3a4db4167206
Author: Cheng Pan <[email protected]>
AuthorDate: Wed Dec 13 20:27:11 2023 +0800

    [KYUUBI-SHADED #31] Move transitve deps of Zookeeper/Curator to sub-package
    
    ### _Why are the changes needed?_
    
    The current name pattern does not cause real issues, it's just for safety, 
i.e. if we create another shaded component that also depends on Guava, the 
existing `<shadedPattern>${shading.prefix}.google</shadedPattern>` would cause 
conflicts.
    
    ### _How was this patch tested?_
    - [ ] Add some test cases that check the changes thoroughly including 
negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [ ] [Run 
test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests)
 locally before make a pull request
    
    Closes #31 from pan3793/package-name.
    
    f7af952 [Cheng Pan] Move transitve deps of Zookeeper/Curator to sub-package
    
    Authored-by: Cheng Pan <[email protected]>
    Signed-off-by: Cheng Pan <[email protected]>
---
 kyuubi-relocated-zookeeper-parent/pom.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kyuubi-relocated-zookeeper-parent/pom.xml 
b/kyuubi-relocated-zookeeper-parent/pom.xml
index e64f760..b4edb6b 100644
--- a/kyuubi-relocated-zookeeper-parent/pom.xml
+++ b/kyuubi-relocated-zookeeper-parent/pom.xml
@@ -87,7 +87,7 @@ under the License.
                                 </relocation>
                                 <relocation>
                                     <pattern>com.codahale.metrics</pattern>
-                                    
<shadedPattern>${shading.prefix}.metrics</shadedPattern>
+                                    
<shadedPattern>${shading.prefix}.zookeeper.metrics</shadedPattern>
                                 </relocation>
                                 <relocation>
                                     <pattern>org.apache.curator</pattern>
@@ -95,7 +95,7 @@ under the License.
                                 </relocation>
                                 <relocation>
                                     <pattern>com.google</pattern>
-                                    
<shadedPattern>${shading.prefix}.google</shadedPattern>
+                                    
<shadedPattern>${shading.prefix}.curator.google</shadedPattern>
                                 </relocation>
                             </relocations>
                         </configuration>

Reply via email to