This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new 10badd538 [KYUUBI #5857] Dependencies CI check when
`dev/dependencyList` changes
10badd538 is described below
commit 10badd53863728cb7d1e5b396f0e2e6cbf7eb44b
Author: sychen <[email protected]>
AuthorDate: Fri Dec 15 14:49:52 2023 +0800
[KYUUBI #5857] Dependencies CI check when `dev/dependencyList` changes
# :mag: Description
## Issue References ๐
This pull request fixes #
## Describe Your Solution ๐ง
Sometimes developers may directly change `dev/dependencyList`, but CI will
not check it, which will cause the subsequent upgraded versions of PR execution
CI to fail.
## Types of changes :bookmark:
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
## Test Plan ๐งช
#### Behavior Without This Pull Request :coffin:
#### Behavior With This Pull Request :tada:
#### Related Unit Tests
---
# Checklists
## ๐ Author Self Checklist
- [ ] My code follows the [style
guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html)
of this project
- [ ] I have performed a self-review
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature
works
- [ ] New and existing unit tests pass locally with my changes
- [ ] This patch was not authored or co-authored using [Generative
Tooling](https://www.apache.org/legal/generative-tooling.html)
## ๐ Committer Pre-Merge Checklist
- [x] Pull request title is okay.
- [x] No license issues.
- [x] Milestone correctly set?
- [ ] Test coverage is ok
- [x] Assignees are selected.
- [x] Minimum number of approvals
- [x] No changes are requested
**Be nice. Be informative.**
Closes #5857 from cxzl25/deps_check.
Closes #5857
f2e1a1d16 [sychen] check
Authored-by: sychen <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
---
.github/workflows/dep.yml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.github/workflows/dep.yml b/.github/workflows/dep.yml
index 7c03720f5..96f49d8d9 100644
--- a/.github/workflows/dep.yml
+++ b/.github/workflows/dep.yml
@@ -26,6 +26,8 @@ on:
# when pom or dependency workflow changes
- '**/pom.xml'
- '.github/workflows/dep.yml'
+ - 'build/dependency.sh'
+ - 'dev/dependencyList'
concurrency:
group: dep-${{ github.head_ref || github.run_id }}
