This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch branch-1.7
in repository https://gitbox.apache.org/repos/asf/kyuubi.git


The following commit(s) were added to refs/heads/branch-1.7 by this push:
     new f5d9cc183 [KYUUBI #5951] [DOC] Improve doc for Session Conf Advisor
f5d9cc183 is described below

commit f5d9cc183bd741e1c3d2a941802aff0853166e6f
Author: hezhao2 <[email protected]>
AuthorDate: Tue Jan 9 09:49:03 2024 +0800

    [KYUUBI #5951] [DOC] Improve doc for Session Conf Advisor
    
    # :mag: Description
    ## Issue References ๐Ÿ”—
    
    This pull request is to improve doc for Session Conf Advisor
    
    ## Describe Your Solution ๐Ÿ”ง
    
    improve doc for Session Conf Advisor
    
    ## Types of changes :bookmark:
    
    - [ ] Bugfix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
    
    ## Test Plan ๐Ÿงช
    
    #### Behavior Without This Pull Request :coffin:
    
    #### Behavior With This Pull Request :tada:
    
    #### Related Unit Tests
    
    ---
    
    # Checklist ๐Ÿ“
    
    - [ ] This patch was not authored or co-authored using [Generative 
Tooling](https://www.apache.org/legal/generative-tooling.html)
    
    **Be nice. Be informative.**
    
    Closes #5951 from zhaohehuhu/Improvement-0108.
    
    Closes #5951
    
    9f2c66210 [hezhao2] Improve doc for Session Conf Advisor
    
    Authored-by: hezhao2 <[email protected]>
    Signed-off-by: Cheng Pan <[email protected]>
    (cherry picked from commit 865a8b75c9e16c3c7a2d17aa1a918c20317eb8e7)
    Signed-off-by: Cheng Pan <[email protected]>
---
 docs/extensions/server/configuration.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/extensions/server/configuration.rst 
b/docs/extensions/server/configuration.rst
index 94b1da9fb..97f503426 100644
--- a/docs/extensions/server/configuration.rst
+++ b/docs/extensions/server/configuration.rst
@@ -53,8 +53,8 @@ We have a custom class ``CustomSessionConfAdvisor``:
 
 .. code-block:: java
 
-   @Override
-   public class CustomSessionConfAdvisor {
+   public class CustomSessionConfAdvisor implements SessionConfAdvisor {
+     @Override
      Map<String, String> getConfOverlay(String user, Map<String, String> 
sessionConf) {
        if ("uly".equals(user)) {
          return Collections.singletonMap("spark.driver.memory", "1G");

Reply via email to