This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch branch-1.8
in repository https://gitbox.apache.org/repos/asf/kyuubi.git


The following commit(s) were added to refs/heads/branch-1.8 by this push:
     new f12e68eb4 [KYUUBI #6158] [MINOR] Remove confusing variable
f12e68eb4 is described below

commit f12e68eb49f7eca79ce8229aebe727e312c6e6e7
Author: wforget <[email protected]>
AuthorDate: Mon Mar 11 16:05:07 2024 +0800

    [KYUUBI #6158] [MINOR] Remove confusing variable
    
    # :mag: Description
    ## Issue References ๐Ÿ”—
    
    This pull request fixes #
    
    ## Describe Your Solution ๐Ÿ”ง
    
    `fSession` refers more to `FlinkSessionImpl.fSession`.
    
    ## Types of changes :bookmark:
    
    - [ ] Bugfix (non-breaking change which fixes an issue)
    - [X] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
    
    ## Test Plan ๐Ÿงช
    
    #### Behavior Without This Pull Request :coffin:
    
    #### Behavior With This Pull Request :tada:
    
    #### Related Unit Tests
    
    ---
    
    # Checklist ๐Ÿ“
    
    - [X] This patch was not authored or co-authored using [Generative 
Tooling](https://www.apache.org/legal/generative-tooling.html)
    
    **Be nice. Be informative.**
    
    Closes #6158 from wForget/hotfix.
    
    Closes #6158
    
    b388b9fd7 [wforget] fix
    51bc0c55d [wforget] comment
    83ed8d2a7 [wforget] [MINOR] Fix confusing variable name
    
    Authored-by: wforget <[email protected]>
    Signed-off-by: Cheng Pan <[email protected]>
    (cherry picked from commit 4def33382febe4e21a55be12ad731812cae8765c)
    Signed-off-by: Cheng Pan <[email protected]>
---
 .../apache/kyuubi/engine/flink/session/FlinkSQLSessionManager.scala | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/session/FlinkSQLSessionManager.scala
 
b/externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/session/FlinkSQLSessionManager.scala
index 18111ac31..83180d360 100644
--- 
a/externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/session/FlinkSQLSessionManager.scala
+++ 
b/externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/session/FlinkSQLSessionManager.scala
@@ -81,9 +81,9 @@ class FlinkSQLSessionManager(engineContext: DefaultContext)
 
   override def closeSession(sessionHandle: SessionHandle): Unit = {
     try {
-      val fSession = super.getSessionOption(sessionHandle)
-      fSession.foreach(s =>
-        
sessionManager.closeSession(s.asInstanceOf[FlinkSessionImpl].fSession.getSessionHandle))
+      super.getSessionOption(sessionHandle).foreach { s =>
+        
sessionManager.closeSession(s.asInstanceOf[FlinkSessionImpl].fSession.getSessionHandle)
+      }
       super.closeSession(sessionHandle)
     } catch {
       case t: Throwable =>

Reply via email to