This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new a937ae760 [KYUUBI #6243] Add missing Impala alias for JDBC engine
a937ae760 is described below

commit a937ae760eb51468929493101fcdb84561db1747
Author: senmiaoliu <[email protected]>
AuthorDate: Wed Apr 3 17:30:42 2024 +0800

    [KYUUBI #6243] Add missing Impala alias for JDBC engine
    
    # :mag: Description
    ## Issue References ๐Ÿ”—
    
    ## Describe Your Solution ๐Ÿ”ง
    
    Please include a summary of the change and which issue is fixed. Please 
also include relevant motivation and context. List any dependencies that are 
required for this change.
    
    ## Types of changes :bookmark:
    
    - [x] Bugfix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
    
    ## Test Plan ๐Ÿงช
    
    #### Behavior Without This Pull Request :coffin:
    
    #### Behavior With This Pull Request :tada:
    
    #### Related Unit Tests
    
    ---
    
    # Checklist ๐Ÿ“
    
    - [ ] This patch was not authored or co-authored using [Generative 
Tooling](https://www.apache.org/legal/generative-tooling.html)
    
    **Be nice. Be informative.**
    
    Closes #6238 from lsm1/branch-conf-add-Impala.
    
    Closes #6243
    
    de3093d6a [senmiaoliu] add Impala conf
    
    Authored-by: senmiaoliu <[email protected]>
    Signed-off-by: Cheng Pan <[email protected]>
---
 docs/configuration/settings.md                                      | 4 ++--
 .../src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala        | 6 +++++-
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/docs/configuration/settings.md b/docs/configuration/settings.md
index 0dbe3a8fb..d939e9122 100644
--- a/docs/configuration/settings.md
+++ b/docs/configuration/settings.md
@@ -158,7 +158,7 @@ You can configure the Kyuubi properties in 
`$KYUUBI_HOME/conf/kyuubi-defaults.co
 | kyuubi.engine.jdbc.connection.password                   | &lt;undefined&gt; 
        | The password is used for connecting to server                         
                                                                                
                                                                                
                                                                                
                                                                                
              [...]
 | kyuubi.engine.jdbc.connection.propagateCredential        | false             
        | Whether to use the session's user and password to connect to database 
                                                                                
                                                                                
                                                                                
                                                                                
              [...]
 | kyuubi.engine.jdbc.connection.properties                                     
       || The additional properties are used for connecting to server           
                                                                                
                                                                                
                                                                                
                                                                                
              [...]
-| kyuubi.engine.jdbc.connection.provider                   | &lt;undefined&gt; 
        | A JDBC connection provider plugin for the Kyuubi Server to establish 
a connection to the JDBC URL. The configuration value should be a subclass of 
`org.apache.kyuubi.engine.jdbc.connection.JdbcConnectionProvider`. Kyuubi 
provides the following built-in implementations: <li>doris: For establishing 
Doris connections.</li> <li>mysql: For establishing MySQL connections.</li> 
<li>phoenix: For establishing [...]
+| kyuubi.engine.jdbc.connection.provider                   | &lt;undefined&gt; 
        | A JDBC connection provider plugin for the Kyuubi Server to establish 
a connection to the JDBC URL. The configuration value should be a subclass of 
`org.apache.kyuubi.engine.jdbc.connection.JdbcConnectionProvider`. Kyuubi 
provides the following built-in implementations: <li>doris: For establishing 
Doris connections.</li> <li>mysql: For establishing MySQL connections.</li> 
<li>phoenix: For establishing [...]
 | kyuubi.engine.jdbc.connection.url                        | &lt;undefined&gt; 
        | The server url that engine will connect to                            
                                                                                
                                                                                
                                                                                
                                                                                
              [...]
 | kyuubi.engine.jdbc.connection.user                       | &lt;undefined&gt; 
        | The user is used for connecting to server                             
                                                                                
                                                                                
                                                                                
                                                                                
              [...]
 | kyuubi.engine.jdbc.driver.class                          | &lt;undefined&gt; 
        | The driver class for JDBC engine connection                           
                                                                                
                                                                                
                                                                                
                                                                                
              [...]
@@ -205,7 +205,7 @@ You can configure the Kyuubi properties in 
`$KYUUBI_HOME/conf/kyuubi-defaults.co
 | kyuubi.engine.trino.java.options                         | &lt;undefined&gt; 
        | The extra Java options for the Trino query engine                     
                                                                                
                                                                                
                                                                                
                                                                                
              [...]
 | kyuubi.engine.trino.memory                               | 1g                
        | The heap memory for the Trino query engine                            
                                                                                
                                                                                
                                                                                
                                                                                
              [...]
 | kyuubi.engine.trino.operation.incremental.collect        | false             
        | When true, the result will be sequentially calculated and returned to 
the trino. It fallback to `kyuubi.operation.incremental.collect`                
                                                                                
                                                                                
                                                                                
              [...]
-| kyuubi.engine.type                                       | SPARK_SQL         
        | Specify the detailed engine supported by Kyuubi. The engine type 
bindings to SESSION scope. This configuration is experimental. Currently, 
available configs are: <ul> <li>SPARK_SQL: specify this engine type will launch 
a Spark engine which can provide all the capacity of the Apache Spark. Note, 
it's a default engine type.</li> <li>FLINK_SQL: specify this engine type will 
launch a Flink engine which c [...]
+| kyuubi.engine.type                                       | SPARK_SQL         
        | Specify the detailed engine supported by Kyuubi. The engine type 
bindings to SESSION scope. This configuration is experimental. Currently, 
available configs are: <ul> <li>SPARK_SQL: specify this engine type will launch 
a Spark engine which can provide all the capacity of the Apache Spark. Note, 
it's a default engine type.</li> <li>FLINK_SQL: specify this engine type will 
launch a Flink engine which c [...]
 | kyuubi.engine.ui.retainedSessions                        | 200               
        | The number of SQL client sessions kept in the Kyuubi Query Engine web 
UI.                                                                             
                                                                                
                                                                                
                                                                                
              [...]
 | kyuubi.engine.ui.retainedStatements                      | 200               
        | The number of statements kept in the Kyuubi Query Engine web UI.      
                                                                                
                                                                                
                                                                                
                                                                                
              [...]
 | kyuubi.engine.ui.stop.enabled                            | true              
        | When true, allows Kyuubi engine to be killed from the Spark Web UI.   
                                                                                
                                                                                
                                                                                
                                                                                
              [...]
diff --git 
a/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala 
b/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
index 9646fec43..170e6950c 100644
--- a/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
+++ b/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
@@ -2173,7 +2173,8 @@ object KyuubiConf {
       " all the capacity of the Hive Server2.</li>" +
       " <li>JDBC: specify this engine type will launch a JDBC engine which can 
forward" +
       " queries to the database system through the certain JDBC driver," +
-      " for now, it supports Doris, MySQL, Phoenix, PostgreSQL, StarRocks and 
ClickHouse.</li>" +
+      " for now, it supports Doris, MySQL, Phoenix, PostgreSQL, StarRocks, 
Impala" +
+      " and ClickHouse.</li>" +
       " <li>CHAT: specify this engine type will launch a Chat engine.</li>" +
       "</ul>")
     .version("1.4.0")
@@ -3068,6 +3069,7 @@ object KyuubiConf {
         "<li>phoenix: For establishing Phoenix connections.</li> " +
         "<li>postgresql: For establishing PostgreSQL connections.</li>" +
         "<li>starrocks: For establishing StarRocks connections.</li>" +
+        "<li>impala: For establishing Impala connections.</li>" +
         "<li>clickhouse: For establishing clickhouse connections.</li>")
       .version("1.6.0")
       .stringConf
@@ -3082,6 +3084,8 @@ object KyuubiConf {
           
"org.apache.kyuubi.engine.jdbc.postgresql.PostgreSQLConnectionProvider"
         case "StarRocks" | "starrocks" | "StarRocksConnectionProvider" =>
           "org.apache.kyuubi.engine.jdbc.starrocks.StarRocksConnectionProvider"
+        case "Impala" | "impala" | "ImpalaConnectionProvider" =>
+          "org.apache.kyuubi.engine.jdbc.impala.ImpalaConnectionProvider"
         case "ClickHouse" | "clickhouse" | "ClickHouseConnectionProvider" =>
           
"org.apache.kyuubi.engine.jdbc.clickhouse.ClickHouseConnectionProvider"
         case other => other

Reply via email to