(kyuubi) branch master updated: [KYUUBI #6312][HELM] Allow attaching annotations to service account

[chengpan]

This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new 3251e7ff8 [KYUUBI #6312][HELM] Allow attaching annotations to service 
account
3251e7ff8 is described below

commit 3251e7ff8efde69b0ca9d81a92e2a6cc3e438e29
Author: Harry <quanghai.ng1...@gmail.com>
AuthorDate: Wed Apr 17 00:05:56 2024 +0800

    [KYUUBI #6312][HELM] Allow attaching annotations to service account
    
    # :mag: Description
    ## Issue References 🔗
    
    This pull request fixes #6312
    
    ## Describe Your Solution 🔧
    
    Please include a summary of the change and which issue is fixed. Please 
also include relevant motivation and context. List any dependencies that are 
required for this change.
    
    ## Types of changes :bookmark:
    
    - [ ] Bugfix (non-breaking change which fixes an issue)
    - [x] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
    
    ## Test Plan 🧪
    
    #### Behavior Without This Pull Request :coffin:
    Not able to attach annotations to service account
    
    #### Related Unit Tests
    Ran `helm template` and rendered correctly as below image
    <img width="428" alt="image" 
src="https://github.com/apache/kyuubi/assets/22145541/d439a846-152b-4939-8ec6-c4f0ba1a4eca";>
    
    ---
    
    # Checklist 📝
    
    - [x] This patch was not authored or co-authored using [Generative 
Tooling](https://www.apache.org/legal/generative-tooling.html)
    
    **Be nice. Be informative.**
    
    Closes #6313 from sudohainguyen/helmchart.
    
    Closes #6312
    
    5abaf139a [Harry] [KYUUBI #6312][HELM] Allow attaching annotations to 
service account
    
    Authored-by: Harry <quanghai.ng1...@gmail.com>
    Signed-off-by: Cheng Pan <cheng...@apache.org>
---
 charts/kyuubi/templates/kyuubi-serviceaccount.yaml | 2 ++
 charts/kyuubi/values.yaml                          | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/charts/kyuubi/templates/kyuubi-serviceaccount.yaml 
b/charts/kyuubi/templates/kyuubi-serviceaccount.yaml
index a8e282a1f..13d20a2f5 100644
--- a/charts/kyuubi/templates/kyuubi-serviceaccount.yaml
+++ b/charts/kyuubi/templates/kyuubi-serviceaccount.yaml
@@ -20,6 +20,8 @@ apiVersion: v1
 kind: ServiceAccount
 metadata:
   name: {{ .Values.serviceAccount.name | default .Release.Name }}
+  annotations:
+    {{- toYaml .Values.serviceAccount.annotations | nindent 4 }}
   labels:
     {{- include "kyuubi.labels" . | nindent 4 }}
 {{- end }}
diff --git a/charts/kyuubi/values.yaml b/charts/kyuubi/values.yaml
index b6b69621e..c02351103 100644
--- a/charts/kyuubi/values.yaml
+++ b/charts/kyuubi/values.yaml
@@ -55,6 +55,8 @@ serviceAccount:
   create: true
   # Specifies ServiceAccount name to be used (created if `create: true`)
   name: ~
+  # Annotations to add to the ServiceAccount
+  annotations: {}
 
 # priorityClass used for Kyuubi server pod
 priorityClass: