This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new 96d8b8e2d [KYUUBI #6445] Normalize extra name for optional Python
distribution dependencies
96d8b8e2d is described below
commit 96d8b8e2de69a617c878447abbf6b63cbe4b5775
Author: camper42 <[email protected]>
AuthorDate: Thu Jun 6 15:06:37 2024 +0800
[KYUUBI #6445] Normalize extra name for optional Python distribution
dependencies
…pendencies
# :mag: Description
## Issue References 🔗
This pull request fixes #6445
## Describe Your Solution 🔧
use `hive-pure-sasl` instead of `hive_pure_sasl` for extra name for
optional distribution dependencies.
this avoid potential `WARNING: pyhive x.y.z does not provide the extra
'hive-pure-sasl'` and missing dependencies when a package depends on
`pyhive[hive_pure_sasl]` and python build system choose to normalize it to
`pyhive[hive-pure-saal]`.
## Types of changes :bookmark:
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
## Test Plan 🧪
#### Behavior Without This Pull Request :coffin:
a package depends on `pyhive[hive_pure_sasl]` may complain `WARNING: pyhive
x.y.z does not provide the extra 'hive-pure-sasl'` and missing dependencies to
support hive feature.
#### Behavior With This Pull Request :tada:
based on my test on our internal pypi, users use `pyhive[hive_pure_sasl]`
are not affected by this change. But we should update README when we release a
new version of pyhive.
#### Related Unit Tests
---
# Checklist 📝
- [x] This patch was not authored or co-authored using [Generative
Tooling](https://www.apache.org/legal/generative-tooling.html)
**Be nice. Be informative.**
Closes #6454 from camper42/python.
Closes #6445
d82e5cae9 [camper42] [KYUUBI #6445] use normalized extra name for optional
distribution dependencies
Authored-by: camper42 <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
---
python/setup.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/python/setup.py b/python/setup.py
index d141ea1b3..9d683ae94 100755
--- a/python/setup.py
+++ b/python/setup.py
@@ -46,7 +46,7 @@ setup(
'presto': ['requests>=1.0.0'],
'trino': ['requests>=1.0.0'],
'hive': ['sasl>=0.2.1', 'thrift>=0.10.0', 'thrift_sasl>=0.1.0'],
- 'hive_pure_sasl': ['pure-sasl>=0.6.2', 'thrift>=0.10.0',
'thrift_sasl>=0.1.0'],
+ 'hive-pure-sasl': ['pure-sasl>=0.6.2', 'thrift>=0.10.0',
'thrift_sasl>=0.1.0'],
'sqlalchemy': ['sqlalchemy>=1.3.0'],
'kerberos': ['requests_kerberos>=0.12.0'],
},
