This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new 3aaa1d6b1 [KYUUBI #6550] Delete 
`updateStrategy.rollingUpdate.maxUnavailable` because it is alpha feature
3aaa1d6b1 is described below

commit 3aaa1d6b1e8377b36b88446106913a97ba88991a
Author: ryosuke-hasebe <[email protected]>
AuthorDate: Tue Jul 23 11:30:20 2024 +0800

    [KYUUBI #6550] Delete `updateStrategy.rollingUpdate.maxUnavailable` because 
it is alpha feature
    
    # :mag: Description
    
    StatefulSet's `updateStrategy.rollingUpdate.maxUnavailable` is being used, 
but this feature is still in the alpha stage. It should not be used by default.
    
    
https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-alpha-or-beta-features:~:text=%E2%80%93-,MaxUnavailableStatefulSet,-false
    
    https://kubernetes.io/blog/2022/05/27/maxunavailable-for-statefulset/
    
    ## Issue References ๐Ÿ”—
    
    None
    
    ## Describe Your Solution ๐Ÿ”ง
    
    I simply removed it. The behavior should not change even after the removal.
    
    ## Types of changes :bookmark:
    
    - [ ] Bugfix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
    
    ## Test Plan ๐Ÿงช
    
    #### Behavior Without This Pull Request :coffin:
    
    #### Behavior With This Pull Request :tada:
    
    #### Related Unit Tests
    
    ---
    
    # Checklist ๐Ÿ“
    
    - [ ] This patch was not authored or co-authored using [Generative 
Tooling](https://www.apache.org/legal/generative-tooling.html)
    
    **Be nice. Be informative.**
    
    Closes #6550 from be-hase/polish-updateStrategy.
    
    Closes #6550
    
    ab31779fd [ryosuke-hasebe] Delete 
updateStrategy.rollingUpdate.maxUnavailable because it is alpha feature
    
    Authored-by: ryosuke-hasebe <[email protected]>
    Signed-off-by: Cheng Pan <[email protected]>
---
 charts/kyuubi/values.yaml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/charts/kyuubi/values.yaml b/charts/kyuubi/values.yaml
index c02351103..e67be9eb8 100644
--- a/charts/kyuubi/values.yaml
+++ b/charts/kyuubi/values.yaml
@@ -39,7 +39,6 @@ revisionHistoryLimit: 10
 updateStrategy:
   type: RollingUpdate
   rollingUpdate:
-    maxUnavailable: 1
     partition: 0
 
 image:

Reply via email to