This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch branch-1.8
in repository https://gitbox.apache.org/repos/asf/kyuubi.git
The following commit(s) were added to refs/heads/branch-1.8 by this push:
new 8d0a53b41 [KYUUBI #6600] Correct usage of `maven.scaladoc.skip`
8d0a53b41 is described below
commit 8d0a53b41c38670f8234462fa6df59512a5cc239
Author: Cheng Pan <[email protected]>
AuthorDate: Fri Aug 9 07:12:26 2024 +0000
[KYUUBI #6600] Correct usage of `maven.scaladoc.skip`
# :mag: Description
It was wrong applied to all goals previously, which caused all
`test-compile`s are skipped.
## Types of changes :bookmark:
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
## Test Plan ๐งช
Let's monitor what CI happens
---
# Checklist ๐
- [x] This patch was not authored or co-authored using [Generative
Tooling](https://www.apache.org/legal/generative-tooling.html)
**Be nice. Be informative.**
Closes #6600 from pan3793/scaladoc.
Closes #6600
86ea6fdd0 [Cheng Pan] scala213
2a76a93d5 [Cheng Pan] Correct usage of maven.scaladoc.skip
Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit c0e5842c79e30a4334adf80c0b4f60d8cfff72b6)
Signed-off-by: Cheng Pan <[email protected]>
---
pom.xml | 47 +++--------------------------------------------
1 file changed, 3 insertions(+), 44 deletions(-)
diff --git a/pom.xml b/pom.xml
index 3b3bbd627..e2c8d429d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1640,8 +1640,6 @@
<version>${maven.plugin.silencer.version}</version>
</compilerPlugin>
</compilerPlugins>
- <!-- only skipping `scala:doc-jar` -->
- <skip>${maven.scaladoc.skip}</skip>
</configuration>
<executions>
<execution>
@@ -1668,6 +1666,9 @@
<goal>doc-jar</goal>
</goals>
<phase>verify</phase>
+ <configuration>
+ <skip>${maven.scaladoc.skip}</skip>
+ </configuration>
</execution>
</executions>
</plugin>
@@ -2137,48 +2138,6 @@
<scala.version>2.13.8</scala.version>
<spark.archive.scala.suffix>-scala${scala.binary.version}</spark.archive.scala.suffix>
</properties>
- <build>
- <pluginManagement>
- <plugins>
- <plugin>
- <groupId>net.alchim31.maven</groupId>
- <artifactId>scala-maven-plugin</artifactId>
- <configuration>
- <scalaVersion>${scala.version}</scalaVersion>
- <recompileMode>incremental</recompileMode>
- <args>
- <arg>-unchecked</arg>
- <arg>-deprecation</arg>
- <arg>-feature</arg>
- <arg>-explaintypes</arg>
-
<arg>-P:silencer:globalFilters=.*deprecated.*</arg>
- <arg>-P:silencer:globalFilters=.*Could not
find any member to link for.*</arg>
- <arg>-P:silencer:globalFilters=.*undefined
in comment for class.*</arg>
- <arg>-Xfatal-warnings</arg>
- <arg>-Ywarn-unused:imports</arg>
- </args>
- <jvmArgs>
- <jvmArg>-Xms1024m</jvmArg>
- <jvmArg>-Xmx1024m</jvmArg>
-
<jvmArg>-XX:ReservedCodeCacheSize=512M</jvmArg>
- </jvmArgs>
- <javacArgs>
-
<javacArg>-Xlint:all,-serial,-path,-try,-processing</javacArg>
- </javacArgs>
- <compilerPlugins>
- <compilerPlugin>
- <groupId>com.github.ghik</groupId>
-
<artifactId>silencer-plugin_${scala.version}</artifactId>
-
<version>${maven.plugin.silencer.version}</version>
- </compilerPlugin>
- </compilerPlugins>
- <!-- only skipping `scala:doc-jar` -->
- <skip>${maven.scaladoc.skip}</skip>
- </configuration>
- </plugin>
- </plugins>
- </pluginManagement>
- </build>
</profile>
<profile>
