This is an automated email from the ASF dual-hosted git repository.
bowenliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new dddb03722d [KYUUBI #6778] [BUILD] allow frontend plugin not to
inherits Maven's http proxy config
dddb03722d is described below
commit dddb03722dd33578c2839011c84647d16f7037a1
Author: Bowen Liang <[email protected]>
AuthorDate: Tue Nov 12 15:20:45 2024 +0800
[KYUUBI #6778] [BUILD] allow frontend plugin not to inherits Maven's http
proxy config
# :mag: Description
## Issue References ๐
## Describe Your Solution ๐ง
- previously, `pnpm install` and `npm install` are forced to inherits HTTP
proxy configs from Maven by the frontend maven plugin
(https://github.com/eirslett/frontend-maven-plugin?tab=readme-ov-file#proxy-settings)
- adding a parameter `maven.plugin.frontend.inheritsProxyConfigFromMave` to
control whether it inherits the proxy configs with false as default value
## Types of changes :bookmark:
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
## Test Plan ๐งช
#### Behavior Without This Pull Request :coffin:
#### Behavior With This Pull Request :tada:
#### Related Unit Tests
---
# Checklist ๐
- [ ] This patch was not authored or co-authored using [Generative
Tooling](https://www.apache.org/legal/generative-tooling.html)
**Be nice. Be informative.**
Closes #6778 from bowenliang123/frontend-build-proxy.
Closes #6778
c8eb2e4f1 [Bowen Liang] inheritsProxyConfigFromMaven
Authored-by: Bowen Liang <[email protected]>
Signed-off-by: Bowen Liang <[email protected]>
---
pom.xml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/pom.xml b/pom.xml
index 0005d54c1e..07976fb23a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -233,6 +233,7 @@
<maven.plugin.enforcer.mojo.rules.version>1.8.0</maven.plugin.enforcer.mojo.rules.version>
<maven.plugin.flatten.version>1.6.0</maven.plugin.flatten.version>
<maven.plugin.frontend.version>1.12.1</maven.plugin.frontend.version>
+
<maven.plugin.frontend.inheritsProxyConfigFromMaven>false</maven.plugin.frontend.inheritsProxyConfigFromMaven>
<maven.plugin.scala.version>4.9.2</maven.plugin.scala.version>
<maven.plugin.scalatest.version>2.2.0</maven.plugin.scalatest.version>
<maven.plugin.scalatest.exclude.tags>org.scalatest.tags.Slow</maven.plugin.scalatest.exclude.tags>
@@ -1786,6 +1787,8 @@
<configuration>
<nodeVersion>${node.version}</nodeVersion>
<pnpmVersion>${pnpm.version}</pnpmVersion>
+
<npmInheritsProxyConfigFromMaven>${maven.plugin.frontend.inheritsProxyConfigFromMaven}</npmInheritsProxyConfigFromMaven>
+
<pnpmInheritsProxyConfigFromMaven>${maven.plugin.frontend.inheritsProxyConfigFromMaven}</pnpmInheritsProxyConfigFromMaven>
</configuration>
</plugin>
</plugins>
