This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new c391d169fe [KYUUBI #6813] [BUILD] Replace `java.version` 1.8 with 8
c391d169fe is described below

commit c391d169fe16d1940115dbbf0a22bcaa6998b76e
Author: Bowen Liang <[email protected]>
AuthorDate: Tue Nov 19 17:22:59 2024 +0800

    [KYUUBI #6813] [BUILD] Replace `java.version` 1.8 with 8
    
    # :mag: Description
    ## Issue References ๐Ÿ”—
    
    This pull request fixes #
    
    ## Describe Your Solution ๐Ÿ”ง
    
    - fix the compilation error on Zulu JDK8 (Zulu 8.82.0.21-cA-macos-aarch64 
with M4 Max chip on MacOS 15.1), when running `build/mvn clean install -pl 
:kyuubi-util -DskipTests -am` command to build a pure Java module,  by 
replacing version code sytle from 1.8 to 8.
    
    
![image](https://github.com/user-attachments/assets/d4d473b5-8db7-49cf-b7d5-6cc23541496c)
    
    ## Types of changes :bookmark:
    
    - [ ] Bugfix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
    
    ## Test Plan ๐Ÿงช
    
    #### Behavior Without This Pull Request :coffin:
    
    #### Behavior With This Pull Request :tada:
    
    #### Related Unit Tests
    
    ---
    
    # Checklist ๐Ÿ“
    
    - [ ] This patch was not authored or co-authored using [Generative 
Tooling](https://www.apache.org/legal/generative-tooling.html)
    
    **Be nice. Be informative.**
    
    Closes #6813 from bowenliang123/java8.
    
    Closes #6813
    
    1a1e3f3a7 [Bowen Liang] set java.version to 8
    
    Authored-by: Bowen Liang <[email protected]>
    Signed-off-by: Cheng Pan <[email protected]>
---
 pom.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pom.xml b/pom.xml
index 1ac1f47d1e..f2a37c519d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -113,7 +113,7 @@
     </distributionManagement>
 
     <properties>
-        <java.version>1.8</java.version>
+        <java.version>8</java.version>
         <maven.version>3.9.9</maven.version>
         <maven.compiler.source>${java.version}</maven.compiler.source>
         <maven.compiler.target>${java.version}</maven.compiler.target>
@@ -1901,10 +1901,10 @@
         <profile>
             <id>java-8</id>
             <activation>
-                <jdk>1.8</jdk>
+                <jdk>8</jdk>
             </activation>
             <properties>
-                <java.version>1.8</java.version>
+                <java.version>8</java.version>
                 <iceberg.version>1.6.1</iceberg.version>
             </properties>
         </profile>

Reply via email to