This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch branch-1.9
in repository https://gitbox.apache.org/repos/asf/kyuubi.git


The following commit(s) were added to refs/heads/branch-1.9 by this push:
     new 6d5b1f8691 [KYUUBI #6820] Explicitly disable attach-scaladocs for pure 
Java modules
6d5b1f8691 is described below

commit 6d5b1f8691495d87088a769d74c8334256c48b04
Author: Cheng Pan <[email protected]>
AuthorDate: Fri Nov 22 17:12:00 2024 +0800

    [KYUUBI #6820] Explicitly disable attach-scaladocs for pure Java modules
    
    ```
    export JAVA_HOME=/path/of/openjdk-17
    build/mvn clean install -DskipTests -Dmaven.scaladoc.skip=false
    ```
    
    ```
    [INFO] --- scala-maven-plugin:4.9.2:doc-jar (attach-scaladocs)  
kyuubi-server-plugin ---
    [INFO] compiler plugin: 
BasicArtifact(com.github.ghik,silencer-plugin_2.12.20,1.7.19,null)
    error: fatal error: object scala in compiler mirror not found.
    ```
    
    - [x] Bugfix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
    
    Successfully run the build command
    ```
    export JAVA_HOME=/path/of/openjdk-17
    build/mvn clean install -DskipTests -Dmaven.scaladoc.skip=false
    ```
    
    ---
    
    - [x] This patch was not authored or co-authored using [Generative 
Tooling](https://www.apache.org/legal/generative-tooling.html)
    
    **Be nice. Be informative.**
    
    Closes #6820 from pan3793/scaladoc.
    
    Closes #6820
    
    f5cee3429 [Cheng Pan] Explicitly disable attach-scaladocs for pure Java 
modules
    
    Authored-by: Cheng Pan <[email protected]>
    Signed-off-by: Cheng Pan <[email protected]>
    (cherry picked from commit 4b506f4cb92f8102f0d0ca9908869cdedbeb07e5)
    Signed-off-by: Cheng Pan <[email protected]>
---
 extensions/server/kyuubi-server-plugin/pom.xml | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/extensions/server/kyuubi-server-plugin/pom.xml 
b/extensions/server/kyuubi-server-plugin/pom.xml
index 43ba2e204c..f2c6d7dbc3 100644
--- a/extensions/server/kyuubi-server-plugin/pom.xml
+++ b/extensions/server/kyuubi-server-plugin/pom.xml
@@ -35,9 +35,12 @@
             <plugin>
                 <groupId>net.alchim31.maven</groupId>
                 <artifactId>scala-maven-plugin</artifactId>
-                <configuration>
-                    <skip>true</skip>
-                </configuration>
+                <executions>
+                    <execution>
+                        <id>attach-scaladocs</id>
+                        <phase>none</phase>
+                    </execution>
+                </executions>
             </plugin>
         </plugins>
     </build>

Reply via email to