Author: simonetripodi
Date: Wed Feb 24 17:57:38 2010
New Revision: 915898
URL: http://svn.apache.org/viewvc?rev=915898&view=rev
Log:
better delegating to beanutils the reflection stuff
Modified:
labs/amber/signature-api/src/main/java/org/apache/labs/amber/signature/signers/AbstractMethodAlgorithm.java
Modified:
labs/amber/signature-api/src/main/java/org/apache/labs/amber/signature/signers/AbstractMethodAlgorithm.java
URL:
http://svn.apache.org/viewvc/labs/amber/signature-api/src/main/java/org/apache/labs/amber/signature/signers/AbstractMethodAlgorithm.java?rev=915898&r1=915897&r2=915898&view=diff
==============================================================================
---
labs/amber/signature-api/src/main/java/org/apache/labs/amber/signature/signers/AbstractMethodAlgorithm.java
(original)
+++
labs/amber/signature-api/src/main/java/org/apache/labs/amber/signature/signers/AbstractMethodAlgorithm.java
Wed Feb 24 17:57:38 2010
@@ -24,6 +24,7 @@
import java.util.Collections;
import java.util.List;
+import org.apache.commons.beanutils.BeanUtils;
import org.apache.commons.codec.net.URLCodec;
import org.apache.labs.amber.signature.descriptors.Service;
import org.apache.labs.amber.signature.message.OAuthParameter;
@@ -224,9 +225,8 @@
if (field.isAnnotationPresent(OAuthParameter.class)) {
OAuthParameter oAuthParameter =
field.getAnnotation(OAuthParameter.class);
if (oAuthParameter.includeInSignature()) {
- field.setAccessible(true);
try {
- Object fieldValue = field.get(message);
+ Object fieldValue = BeanUtils.getProperty(message,
field.getName());
if (fieldValue == null &&
!oAuthParameter.optional()) {
throw new SignatureException(new
StringBuilder("OAuth parameter '")
@@ -240,11 +240,9 @@
encodeAndAddParameter(oAuthParameter.name(),
String.valueOf(fieldValue), parametersList);
} catch (Exception e) {
throw new SignatureException(new StringBuilder("An
error occurred while getting '")
- .append(field)
- .append("' value, see nested exception")
- .toString(), e);
- } finally {
- field.setAccessible(false);
+ .append(field)
+ .append("' value, see nested
exception")
+ .toString(), e);
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
