LENS-1246 : Fix NPE in explainFailedAttempt in Lens Client
Project: http://git-wip-us.apache.org/repos/asf/lens/repo Commit: http://git-wip-us.apache.org/repos/asf/lens/commit/fbe44ff0 Tree: http://git-wip-us.apache.org/repos/asf/lens/tree/fbe44ff0 Diff: http://git-wip-us.apache.org/repos/asf/lens/diff/fbe44ff0 Branch: refs/heads/master Commit: fbe44ff0be1ceca163a3d74310fa10b5ac5918eb Parents: 68e01c2 Author: Rajat Khandelwal <[email protected]> Authored: Thu Aug 4 10:51:56 2016 +0530 Committer: Amareshwari Sriramadasu <[email protected]> Committed: Thu Aug 4 10:52:35 2016 +0530 ---------------------------------------------------------------------- .../apache/lens/client/LensClientSingletonWrapper.java | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/lens/blob/fbe44ff0/lens-client/src/main/java/org/apache/lens/client/LensClientSingletonWrapper.java ---------------------------------------------------------------------- diff --git a/lens-client/src/main/java/org/apache/lens/client/LensClientSingletonWrapper.java b/lens-client/src/main/java/org/apache/lens/client/LensClientSingletonWrapper.java index 4629559..3fd754e 100644 --- a/lens-client/src/main/java/org/apache/lens/client/LensClientSingletonWrapper.java +++ b/lens-client/src/main/java/org/apache/lens/client/LensClientSingletonWrapper.java @@ -58,15 +58,21 @@ public class LensClientSingletonWrapper { log.error("failed login attempt", e); switch (e.getErrorCode()) { case 401: - System.console().printf("username/password combination incorrect.\n"); + printError("username/password combination incorrect."); break; case 500: - System.console().printf("server unresponsive, Returned error code 500\n"); + printError("server unresponsive, Returned error code 500"); break; default: - System.console().printf("ERROR: " + e.getMessage() + "\n"); + printError("ERROR: " + e.getMessage()); } } + private void printError(String error) { + if (System.console() != null) { + System.console().printf(error + "\n"); + } + log.error(error); + } public LensClient getClient() { if (client == null) {
