Repository: incubator-lens Updated Branches: refs/heads/master e0b0c4c55 -> 063a3766f
LENS-563 : Accepting valid columns of length more than 4000 for a cube (Akshay Goyal via amareshwari) Project: http://git-wip-us.apache.org/repos/asf/incubator-lens/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-lens/commit/063a3766 Tree: http://git-wip-us.apache.org/repos/asf/incubator-lens/tree/063a3766 Diff: http://git-wip-us.apache.org/repos/asf/incubator-lens/diff/063a3766 Branch: refs/heads/master Commit: 063a3766fa86a584bce8a4834fc657347b20ad7a Parents: e0b0c4c Author: Akshay Goyal <[email protected]> Authored: Fri May 22 09:47:49 2015 +0530 Committer: Amareshwari Sriramadasu <[email protected]> Committed: Fri May 22 09:47:49 2015 +0530 ---------------------------------------------------------------------- lens-api/src/main/resources/cube-0.1.xsd | 16 ++++++++++------ .../apache/lens/cube/metadata/CubeFactTable.java | 3 ++- 2 files changed, 12 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/063a3766/lens-api/src/main/resources/cube-0.1.xsd ---------------------------------------------------------------------- diff --git a/lens-api/src/main/resources/cube-0.1.xsd b/lens-api/src/main/resources/cube-0.1.xsd index 1918e5c..1e8d71d 100644 --- a/lens-api/src/main/resources/cube-0.1.xsd +++ b/lens-api/src/main/resources/cube-0.1.xsd @@ -1121,18 +1121,22 @@ <xs:documentation> Properties that can be set for a fact are - 1. cube.fact.{fact-name}.valid.columns : comma separated column names which are valid in the fact. - 2. cube.fact.is.aggregated : Defaults to true. If the fact is a raw fact, this should be set to false, + 1. cube.fact.{fact-name}.valid.columns.size : This should be set to number of + cube.fact.{fact-name}.valid.columns strings. + 2. cube.fact.{fact-name}.valid.columns{i} : This should be set to comma separated column names which are + valid in the fact, such that 0 <= i < cube.fact.{fact-name}.valid.columns.size and each of + cube.fact.{fact-name}.valid.columns{i} has maximum length of 3999. + 3. cube.fact.is.aggregated : Defaults to true. If the fact is a raw fact, this should be set to false, otherwise true. - 3. cube.timedim.relation.{time_dim1}: See the same property in cube. Fact tables can override the property. - 4. cube.fact.absolute.start.time: start time of the fact. For queries that ask for time before this, + 4. cube.timedim.relation.{time_dim1}: See the same property in cube. Fact tables can override the property. + 5. cube.fact.absolute.start.time: start time of the fact. For queries that ask for time before this, this fact is not a candidate. Time format can be as you would specify in the time_range_in clause. i.e. yyyy[-mm[-dd[-hh[:MM[:ss[,SSS]]]]]] - 5. cube.fact.relative.start.time: Here you can specify fact's relative validity relative to current time. + 6. cube.fact.relative.start.time: Here you can specify fact's relative validity relative to current time. Useful if you want to specify e.g. this fact is valid for today - 90 days. Can be specified as just a time difference e.g. "-90 days". Or can be specified in relative syntax. e.g. now.year or now.day - 6 hour etc. - 6. cube.fact.absolute.end.time: If you're deprecating this fact, put the final date till which the data of + 7. cube.fact.absolute.end.time: If you're deprecating this fact, put the final date till which the data of the fact will be valid here. Format same as absolute start time. </xs:documentation> </xs:annotation> http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/063a3766/lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java ---------------------------------------------------------------------- diff --git a/lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java b/lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java index 5ea715d..a6cff41 100644 --- a/lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java +++ b/lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java @@ -221,7 +221,8 @@ public final class CubeFactTable extends AbstractCubeTable { * @return */ public List<String> getValidColumns() { - String validColsStr = getProperties().get(MetastoreUtil.getValidColumnsKey(getName())); + String validColsStr = + MetastoreUtil.getNamedStringValue(getProperties(), MetastoreUtil.getValidColumnsKey(getName())); return validColsStr == null ? null : Arrays.asList(StringUtils.split(validColsStr.toLowerCase(), ',')); }
