[ 
https://issues.apache.org/jira/browse/LIBCLOUD-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749730#comment-13749730
 ] 

Michael Bennett edited comment on LIBCLOUD-384 at 8/25/13 8:15 PM:
-------------------------------------------------------------------

I've attached a sample debug log and I've stripped out all irrelevant lines. As 
you can see, the response contains a <publicIpAddress> element that contains 
the valid IP address of my running node. Line 585 in the opsource driver simply 
returns an empty list and never checks for the public IP. 
https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/opsource.py#L585

I've created a pull request with my changes and included a test (which also 
adds public IP to the test fixture):
https://github.com/apache/libcloud/pull/137
(Please ignore pull request 136 as I have deleted the commit for it in my 
branch. I made a mistake in my code that added an empty string to the public IP 
list when calling findtext for the public ip returns None)
                
      was (Author: bennettaur):
    I've attached a sample debug log and I've stripped out all irrelevant 
lines. As you can see, the response contains a <publicIpAddress> element that 
contains the valid IP address of my running node. Line 585 in the opsource 
driver simply returns an empty list and never checks for the public IP. 
https://github.com/apache/libcloud/blob/trunk/libcloud/compute/drivers/opsource.py#L585

I've created a pull request with my changes and included a test (which also 
adds public IP to the test fixture):
https://github.com/apache/libcloud/pull/136
                  
> Opsource driver doesn't put public ip in Nodes
> ----------------------------------------------
>
>                 Key: LIBCLOUD-384
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-384
>             Project: Libcloud
>          Issue Type: Improvement
>          Components: Compute
>            Reporter: Michael Bennett
>            Priority: Trivial
>         Attachments: debug.txt
>
>
> When calling list_nodes() from an OpsourceNodeDriver instance, the nodes 
> listed do not contain a public IP ever. The public IP is available in the XML 
> response from the API

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to