[
https://issues.apache.org/jira/browse/LIBCLOUD-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomaz Muraus resolved LIBCLOUD-247.
-----------------------------------
Resolution: Fixed
Assignee: Tomaz Muraus
Second issue has also already been fixed in trunk in two days:
1. We switched to "is not None" check
2. We switched to ENUM values being string instead of an int
> dns drivers - update_record
> ---------------------------
>
> Key: LIBCLOUD-247
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-247
> Project: Libcloud
> Issue Type: Bug
> Components: Core
> Reporter: Dinesh Bhoopathy
> Assignee: Tomaz Muraus
> Priority: Minor
> Labels: dns
>
> I know its an edge case but say when we do update_record() and change the
> 'type' for the record
> and if it 'is' RecordType.A then the value for it is 0 and in all the dns
> drivers I see things like 'if type:' which will never be True isn't it ?
> and just fft isn't it a good practice not using keywords like 'type' . Guess
> we could've used something like record_type or zone_type ? or simply like pep
> says use 'single_trailing_underscore_:'
> http://www.python.org/dev/peps/pep-0008/
> I guess we need to set those record type constants starting from 1 in
> RecordType class.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
