This is an automated email from the ASF dual-hosted git repository.
casion pushed a commit to branch dev-1.3.0
in repository https://gitbox.apache.org/repos/asf/incubator-linkis.git
The following commit(s) were added to refs/heads/dev-1.3.0 by this push:
new aa8dcc2fa fix NPE of node metrics report (#3583)
aa8dcc2fa is described below
commit aa8dcc2fa79d3ea5866f12ba04f479e1bb0fd3d5
Author: aiceflower <[email protected]>
AuthorDate: Fri Sep 30 17:46:24 2022 +0800
fix NPE of node metrics report (#3583)
---
.../persistence/impl/DefaultNodeMetricManagerPersistence.java | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git
a/linkis-computation-governance/linkis-manager/linkis-manager-persistence/src/main/java/org/apache/linkis/manager/persistence/impl/DefaultNodeMetricManagerPersistence.java
b/linkis-computation-governance/linkis-manager/linkis-manager-persistence/src/main/java/org/apache/linkis/manager/persistence/impl/DefaultNodeMetricManagerPersistence.java
index 15a578c7f..293c213f4 100644
---
a/linkis-computation-governance/linkis-manager/linkis-manager-persistence/src/main/java/org/apache/linkis/manager/persistence/impl/DefaultNodeMetricManagerPersistence.java
+++
b/linkis-computation-governance/linkis-manager/linkis-manager-persistence/src/main/java/org/apache/linkis/manager/persistence/impl/DefaultNodeMetricManagerPersistence.java
@@ -77,7 +77,11 @@ public class DefaultNodeMetricManagerPersistence implements
NodeMetricManagerPer
@Override
public void addOrupdateNodeMetrics(NodeMetrics nodeMetrics) throws
PersistenceErrorException {
- PersistenceNodeMetrics persistenceNodeMetrics = new
PersistenceNodeMetrics();
+ if (null == nodeMetrics.getServiceInstance()) {
+ logger.warn(
+ "The request of update node metrics was ignored, because the node
metrics service instance is null");
+ return;
+ }
String instance = nodeMetrics.getServiceInstance().getInstance();
// todo 异常信息后面统一处理
PersistenceNode node = nodeManagerMapper.getNodeInstance(instance);
@@ -90,6 +94,7 @@ public class DefaultNodeMetricManagerPersistence implements
NodeMetricManagerPer
}
int isInstanceIdExist =
nodeMetricManagerMapper.checkInstanceExist(instance);
// 是否存在
+ PersistenceNodeMetrics persistenceNodeMetrics = new
PersistenceNodeMetrics();
if (isInstanceIdExist == 0) {
persistenceNodeMetrics.setInstance(nodeMetrics.getServiceInstance().getInstance());
persistenceNodeMetrics.setHealthy(nodeMetrics.getHealthy());
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
