This is an automated email from the ASF dual-hosted git repository.
peacewong pushed a commit to branch dev-1.3.2
in repository https://gitbox.apache.org/repos/asf/linkis.git
The following commit(s) were added to refs/heads/dev-1.3.2 by this push:
new 55267ff35 revert EngineTypeLabel (#4406)
55267ff35 is described below
commit 55267ff3579fc7daa62f12beeb9d4fcfcb4de6f1
Author: aiceflower <[email protected]>
AuthorDate: Fri Mar 24 18:17:58 2023 +0800
revert EngineTypeLabel (#4406)
Co-authored-by: aiceflower <[email protected]>
---
.../label/entity/engine/EngineTypeLabel.java | 15 ------------
.../label/entity/engine/EngineTypeLabelTest.java | 28 +---------------------
2 files changed, 1 insertion(+), 42 deletions(-)
diff --git
a/linkis-computation-governance/linkis-manager/linkis-label-common/src/main/java/org/apache/linkis/manager/label/entity/engine/EngineTypeLabel.java
b/linkis-computation-governance/linkis-manager/linkis-label-common/src/main/java/org/apache/linkis/manager/label/entity/engine/EngineTypeLabel.java
index 912f6c9f9..09492b146 100644
---
a/linkis-computation-governance/linkis-manager/linkis-label-common/src/main/java/org/apache/linkis/manager/label/entity/engine/EngineTypeLabel.java
+++
b/linkis-computation-governance/linkis-manager/linkis-label-common/src/main/java/org/apache/linkis/manager/label/entity/engine/EngineTypeLabel.java
@@ -74,19 +74,4 @@ public class EngineTypeLabel extends GenericLabel implements
EngineNodeLabel, EM
public Boolean isEmpty() {
return StringUtils.isBlank(getEngineType()) ||
StringUtils.isBlank(getVersion());
}
-
- @Override
- protected void setStringValue(String stringValue) {
- String version;
- String engineType = stringValue.split("-")[0];
-
- if (engineType.equals("*")) {
- version = stringValue.replaceFirst("[" + engineType + "]-", "");
- } else {
- version = stringValue.replaceFirst(engineType + "-", "");
- }
-
- setEngineType(engineType);
- setVersion(version);
- }
}
diff --git
a/linkis-computation-governance/linkis-manager/linkis-label-common/src/test/java/org/apache/linkis/manager/label/entity/engine/EngineTypeLabelTest.java
b/linkis-computation-governance/linkis-manager/linkis-label-common/src/test/java/org/apache/linkis/manager/label/entity/engine/EngineTypeLabelTest.java
index cc4171b43..dd90e1050 100644
---
a/linkis-computation-governance/linkis-manager/linkis-label-common/src/test/java/org/apache/linkis/manager/label/entity/engine/EngineTypeLabelTest.java
+++
b/linkis-computation-governance/linkis-manager/linkis-label-common/src/test/java/org/apache/linkis/manager/label/entity/engine/EngineTypeLabelTest.java
@@ -17,31 +17,5 @@
package org.apache.linkis.manager.label.entity.engine;
-import org.apache.linkis.manager.label.builder.factory.LabelBuilderFactory;
-import
org.apache.linkis.manager.label.builder.factory.LabelBuilderFactoryContext;
-
-import org.junit.jupiter.api.Assertions;
-import org.junit.jupiter.api.Test;
-
/** EngineTypeLabel Tester */
-public class EngineTypeLabelTest {
-
- @Test
- public void testSetStringValue() {
- String engineType = "hive";
- String version = "1.1.0-cdh5.12.0";
-
- String engineType1 = "*";
- String version1 = "*";
-
- LabelBuilderFactory labelBuilderFactory =
LabelBuilderFactoryContext.getLabelBuilderFactory();
- EngineTypeLabel engineTypeLabel =
labelBuilderFactory.createLabel(EngineTypeLabel.class);
- engineTypeLabel.setStringValue(engineType + "-" + version);
- Assertions.assertEquals(engineTypeLabel.getEngineType(), engineType);
- Assertions.assertEquals(engineTypeLabel.getVersion(), version);
-
- engineTypeLabel.setStringValue(engineType1 + "-" + version1);
- Assertions.assertEquals(engineTypeLabel.getEngineType(), engineType1);
- Assertions.assertEquals(engineTypeLabel.getVersion(), version1);
- }
-}
+public class EngineTypeLabelTest {}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
