The branch master has been updated. The following is a summary of the commits. Further details on each commit can be found below.
from: 76d3efc06a08ff9223aeaff3a7d7632b030c63d4 4bb15e1... Start pulling apart the monolithic H_S_Facebook class into a more OO design. 9a2dfad... Move batch functionality to it's own class. Fix visibility of some methods and members. fd762a8... More horde-ish method names a9dc4c1... Move these constants to the batch object c9593bf... Try to keep the example doc in-line with changes as I work... More camelCase method names.. ----------------------------------------------------------------------- commit 4bb15e1f5bcdbe677e2aa3c0ec4f7f83ec5666c2 Author: Michael J. Rubinsky <[email protected]> Date: Tue Feb 17 19:39:17 2009 -0500 Start pulling apart the monolithic H_S_Facebook class into a more OO design. This one pulls out request related code into H_S_Facebook_Request and also adds a (mosty empty) H_S_Facebook_BatchRequest. .../lib/Horde/Service/Facebook.php | 163 ++++---------------- .../lib/Horde/Service/Facebook/BatchRequest.php | 9 + .../lib/Horde/Service/Facebook/Request.php | 107 +++++++++++++ framework/Service_Facebook/package.xml | 5 + 4 files changed, 154 insertions(+), 130 deletions(-) create mode 100644 framework/Service_Facebook/lib/Horde/Service/Facebook/BatchRequest.php create mode 100644 framework/Service_Facebook/lib/Horde/Service/Facebook/Request.php http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook.php?rt=horde-hatchery&r1=76d3efc06a08ff9223aeaff3a7d7632b030c63d4&r2=4bb15e1f5bcdbe677e2aa3c0ec4f7f83ec5666c2 http://git.horde.org/co.php/framework/Service_Facebook/lib/Horde/Service/Facebook/BatchRequest.php?rt=horde-hatchery&r=4bb15e1f5bcdbe677e2aa3c0ec4f7f83ec5666c2 http://git.horde.org/co.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Request.php?rt=horde-hatchery&r=4bb15e1f5bcdbe677e2aa3c0ec4f7f83ec5666c2 http://git.horde.org/diff.php/framework/Service_Facebook/package.xml?rt=horde-hatchery&r1=997b9faa7dc80655cdbb27ed71c69cd854d46a80&r2=4bb15e1f5bcdbe677e2aa3c0ec4f7f83ec5666c2 ----------------------------------------------------------------------- commit 9a2dfad73a982b29792e67118ccae1ee243ce255 Author: Michael J. Rubinsky <[email protected]> Date: Tue Feb 17 20:11:21 2009 -0500 Move batch functionality to it's own class. Fix visibility of some methods and members. .../lib/Horde/Service/Facebook.php | 74 ++++---------------- .../lib/Horde/Service/Facebook/BatchRequest.php | 71 ++++++++++++++++++- .../lib/Horde/Service/Facebook/Request.php | 14 ++-- 3 files changed, 90 insertions(+), 69 deletions(-) http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook.php?rt=horde-hatchery&r1=4bb15e1f5bcdbe677e2aa3c0ec4f7f83ec5666c2&r2=9a2dfad73a982b29792e67118ccae1ee243ce255 http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook/BatchRequest.php?rt=horde-hatchery&r1=4bb15e1f5bcdbe677e2aa3c0ec4f7f83ec5666c2&r2=9a2dfad73a982b29792e67118ccae1ee243ce255 http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Request.php?rt=horde-hatchery&r1=4bb15e1f5bcdbe677e2aa3c0ec4f7f83ec5666c2&r2=9a2dfad73a982b29792e67118ccae1ee243ce255 ----------------------------------------------------------------------- commit fd762a8ea76af265c0d590d683015e061885bd21 Author: Michael J. Rubinsky <[email protected]> Date: Tue Feb 17 20:24:37 2009 -0500 More horde-ish method names .../lib/Horde/Service/Facebook/BatchRequest.php | 6 +++--- .../lib/Horde/Service/Facebook/Request.php | 20 ++++++++++---------- 2 files changed, 13 insertions(+), 13 deletions(-) http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook/BatchRequest.php?rt=horde-hatchery&r1=9a2dfad73a982b29792e67118ccae1ee243ce255&r2=fd762a8ea76af265c0d590d683015e061885bd21 http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Request.php?rt=horde-hatchery&r1=9a2dfad73a982b29792e67118ccae1ee243ce255&r2=fd762a8ea76af265c0d590d683015e061885bd21 ----------------------------------------------------------------------- commit a9dc4c19489a35ae16e638435c009a81d9120e71 Author: Michael J. Rubinsky <[email protected]> Date: Tue Feb 17 20:35:28 2009 -0500 Move these constants to the batch object .../lib/Horde/Service/Facebook.php | 12 +------ .../lib/Horde/Service/Facebook/BatchRequest.php | 30 ++++++++++++++++++- 2 files changed, 30 insertions(+), 12 deletions(-) http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook.php?rt=horde-hatchery&r1=9a2dfad73a982b29792e67118ccae1ee243ce255&r2=a9dc4c19489a35ae16e638435c009a81d9120e71 http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook/BatchRequest.php?rt=horde-hatchery&r1=fd762a8ea76af265c0d590d683015e061885bd21&r2=a9dc4c19489a35ae16e638435c009a81d9120e71 ----------------------------------------------------------------------- commit c9593bf01b1b2628830cf4ad9099f0a11c67995f Author: Michael J. Rubinsky <[email protected]> Date: Tue Feb 17 20:40:55 2009 -0500 Try to keep the example doc in-line with changes as I work... More camelCase method names.. .../Service_Facebook/doc/facebook_example.php | 50 +++++++++++++++++--- .../lib/Horde/Service/Facebook.php | 4 +- 2 files changed, 45 insertions(+), 9 deletions(-) http://git.horde.org/diff.php/framework/Service_Facebook/doc/facebook_example.php?rt=horde-hatchery&r1=134bf42dca594bf5baf6a18f7ae6187e9fce2fac&r2=c9593bf01b1b2628830cf4ad9099f0a11c67995f http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook.php?rt=horde-hatchery&r1=a9dc4c19489a35ae16e638435c009a81d9120e71&r2=c9593bf01b1b2628830cf4ad9099f0a11c67995f __ commits mailing list Frequently Asked Questions: http://horde.org/faq/ To unsubscribe, mail: [email protected]
