The branch "master" has been updated. The following is a summary of the commits.
from: 70932424d28db3b2ab3ff5ac6de10298e4267558 7e867eb... More rewriting of Facebook lib. 8579a9e... Better method names 9bb7f5c... Move Friends methods to a dedicated class, fix class header in Fql.php ddbc372... Notification methods to it's own class d9a3058... If we don't have a request object in $context, check for a controller and get it from there. 8dec5ec... typo 4a03755... sigh... fix exception class name ae68d9e... ...and actually *keep* the required object. 3d77175... Fix visibility and names of some members 5f6106e... Move Users methods to a new class acfc756... Can't cache the session_key in the method classes, since we may set a new session_key after we instantiate one of the classes. ----------------------------------------------------------------------- commit 7e867ebb79aa5265a47b91e9bd77e5da436c1dbd Author: Michael J. Rubinsky <[email protected]> Date: Tue Feb 24 10:47:48 2009 -0500 More rewriting of Facebook lib. Move FQL queries and Events methods to separate classes. Don't *always* assume we want to pass the session_key. Break out some common code into a Base class framework/Service_Facebook/lib/Horde/Service/Facebook.php | 173 +---- framework/Service_Facebook/lib/Horde/Service/Facebook/Auth.php | 41 +- framework/Service_Facebook/lib/Horde/Service/Facebook/Base.php | 26 + framework/Service_Facebook/lib/Horde/Service/Facebook/Events.php | 129 +++ framework/Service_Facebook/lib/Horde/Service/Facebook/Fql.php | 28 + framework/Service_Facebook/lib/Horde/Service/Facebook/Request.php | 3 - framework/Service_Facebook/package.xml | 4 + 7 files changed, 218 insertions(+), 186 deletions(-) create mode 100644 framework/Service_Facebook/lib/Horde/Service/Facebook/Base.php create mode 100644 framework/Service_Facebook/lib/Horde/Service/Facebook/Events.php create mode 100644 framework/Service_Facebook/lib/Horde/Service/Facebook/Fql.php http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook.php?rt=horde-hatchery&r1=91ce0793f53331a847a51ca762f491e8be5bf10c&r2=7e867ebb79aa5265a47b91e9bd77e5da436c1dbd http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Auth.php?rt=horde-hatchery&r1=cff033534d7073c1e9b5bd0683da250239bcf8c3&r2=7e867ebb79aa5265a47b91e9bd77e5da436c1dbd http://git.horde.org/co.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Base.php?rt=horde-hatchery&r=7e867ebb79aa5265a47b91e9bd77e5da436c1dbd http://git.horde.org/co.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Events.php?rt=horde-hatchery&r=7e867ebb79aa5265a47b91e9bd77e5da436c1dbd http://git.horde.org/co.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Fql.php?rt=horde-hatchery&r=7e867ebb79aa5265a47b91e9bd77e5da436c1dbd http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Request.php?rt=horde-hatchery&r1=91ce0793f53331a847a51ca762f491e8be5bf10c&r2=7e867ebb79aa5265a47b91e9bd77e5da436c1dbd http://git.horde.org/diff.php/framework/Service_Facebook/package.xml?rt=horde-hatchery&r1=91ce0793f53331a847a51ca762f491e8be5bf10c&r2=7e867ebb79aa5265a47b91e9bd77e5da436c1dbd ----------------------------------------------------------------------- commit 8579a9e568826b28987468db74fb979beb3fe03a Author: Michael J. Rubinsky <[email protected]> Date: Tue Feb 24 10:54:18 2009 -0500 Better method names framework/Service_Facebook/lib/Horde/Service/Facebook/Events.php | 12 +++--- 1 files changed, 6 insertions(+), 6 deletions(-) http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Events.php?rt=horde-hatchery&r1=7e867ebb79aa5265a47b91e9bd77e5da436c1dbd&r2=8579a9e568826b28987468db74fb979beb3fe03a ----------------------------------------------------------------------- commit 9bb7f5c5832167ffe463a9823a8ae4c7ebf9bd86 Author: Michael J. Rubinsky <[email protected]> Date: Tue Feb 24 11:00:54 2009 -0500 Move Friends methods to a dedicated class, fix class header in Fql.php framework/Service_Facebook/lib/Horde/Service/Facebook.php | 53 --- framework/Service_Facebook/lib/Horde/Service/Facebook/Fql.php | 6 + framework/Service_Facebook/lib/Horde/Service/Facebook/Friends.php | 85 +++++ framework/Service_Facebook/package.xml | 3 +- 4 files changed, 93 insertions(+), 54 deletions(-) create mode 100644 framework/Service_Facebook/lib/Horde/Service/Facebook/Friends.php http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook.php?rt=horde-hatchery&r1=7e867ebb79aa5265a47b91e9bd77e5da436c1dbd&r2=9bb7f5c5832167ffe463a9823a8ae4c7ebf9bd86 http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Fql.php?rt=horde-hatchery&r1=7e867ebb79aa5265a47b91e9bd77e5da436c1dbd&r2=9bb7f5c5832167ffe463a9823a8ae4c7ebf9bd86 http://git.horde.org/co.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Friends.php?rt=horde-hatchery&r=9bb7f5c5832167ffe463a9823a8ae4c7ebf9bd86 http://git.horde.org/diff.php/framework/Service_Facebook/package.xml?rt=horde-hatchery&r1=7e867ebb79aa5265a47b91e9bd77e5da436c1dbd&r2=9bb7f5c5832167ffe463a9823a8ae4c7ebf9bd86 ----------------------------------------------------------------------- commit ddbc37266f5270df7f95f91710eacadb774e6d0a Author: Michael J. Rubinsky <[email protected]> Date: Tue Feb 24 12:18:37 2009 -0500 Notification methods to it's own class framework/Service_Facebook/lib/Horde/Service/Facebook.php | 120 ++--- .../Service_Facebook/lib/Horde/Service/Facebook/Notifications.php | 83 +++ framework/Service_Facebook/package.xml | 2 + 3 files changed, 127 insertions(+), 78 deletions(-) create mode 100644 framework/Service_Facebook/lib/Horde/Service/Facebook/Notifications.php http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook.php?rt=horde-hatchery&r1=9bb7f5c5832167ffe463a9823a8ae4c7ebf9bd86&r2=ddbc37266f5270df7f95f91710eacadb774e6d0a http://git.horde.org/co.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Notifications.php?rt=horde-hatchery&r=ddbc37266f5270df7f95f91710eacadb774e6d0a http://git.horde.org/diff.php/framework/Service_Facebook/package.xml?rt=horde-hatchery&r1=9bb7f5c5832167ffe463a9823a8ae4c7ebf9bd86&r2=ddbc37266f5270df7f95f91710eacadb774e6d0a ----------------------------------------------------------------------- commit d9a30589419f7d58d7192c7cf663210b5312d2eb Author: Michael J. Rubinsky <[email protected]> Date: Tue Feb 24 12:22:13 2009 -0500 If we don't have a request object in $context, check for a controller and get it from there. framework/Service_Facebook/lib/Horde/Service/Facebook.php | 18 +++++------- 1 files changed, 8 insertions(+), 10 deletions(-) http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook.php?rt=horde-hatchery&r1=ddbc37266f5270df7f95f91710eacadb774e6d0a&r2=d9a30589419f7d58d7192c7cf663210b5312d2eb ----------------------------------------------------------------------- commit 8dec5ec8d1a38ff5a9d9036c078d8646eddf99f5 Author: Michael J. Rubinsky <[email protected]> Date: Tue Feb 24 12:24:18 2009 -0500 typo framework/Service_Facebook/lib/Horde/Service/Facebook/Auth.php | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Auth.php?rt=horde-hatchery&r1=7e867ebb79aa5265a47b91e9bd77e5da436c1dbd&r2=8dec5ec8d1a38ff5a9d9036c078d8646eddf99f5 ----------------------------------------------------------------------- commit 4a037558cec4614b9a5a36f1bbb80e4241ddd0ef Author: Michael J. Rubinsky <[email protected]> Date: Tue Feb 24 12:25:39 2009 -0500 sigh... fix exception class name framework/Service_Facebook/lib/Horde/Service/Facebook/Friends.php | 6 ++-- .../Service_Facebook/lib/Horde/Service/Facebook/Notifications.php | 6 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Friends.php?rt=horde-hatchery&r1=9bb7f5c5832167ffe463a9823a8ae4c7ebf9bd86&r2=4a037558cec4614b9a5a36f1bbb80e4241ddd0ef http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Notifications.php?rt=horde-hatchery&r1=ddbc37266f5270df7f95f91710eacadb774e6d0a&r2=4a037558cec4614b9a5a36f1bbb80e4241ddd0ef ----------------------------------------------------------------------- commit ae68d9e2d52eb7dfba8cdae920ccebfa997036f6 Author: Michael J. Rubinsky <[email protected]> Date: Tue Feb 24 12:29:29 2009 -0500 ...and actually *keep* the required object. framework/Service_Facebook/lib/Horde/Service/Facebook.php | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook.php?rt=horde-hatchery&r1=d9a30589419f7d58d7192c7cf663210b5312d2eb&r2=ae68d9e2d52eb7dfba8cdae920ccebfa997036f6 ----------------------------------------------------------------------- commit 3d771753c4b857b9c765422991b4d4ac066439ff Author: Michael J. Rubinsky <[email protected]> Date: Wed Feb 25 13:21:35 2009 -0500 Fix visibility and names of some members framework/Service_Facebook/lib/Horde/Service/Facebook.php | 19 ++++---- framework/Service_Facebook/lib/Horde/Service/Facebook/Base.php | 12 ++++- 2 files changed, 19 insertions(+), 12 deletions(-) http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook.php?rt=horde-hatchery&r1=ae68d9e2d52eb7dfba8cdae920ccebfa997036f6&r2=3d771753c4b857b9c765422991b4d4ac066439ff http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Base.php?rt=horde-hatchery&r1=7e867ebb79aa5265a47b91e9bd77e5da436c1dbd&r2=3d771753c4b857b9c765422991b4d4ac066439ff ----------------------------------------------------------------------- commit 5f6106ecdf8b0d5e9a79384be526b8a66d7d714b Author: Michael J. Rubinsky <[email protected]> Date: Wed Feb 25 13:47:33 2009 -0500 Move Users methods to a new class framework/Service_Facebook/lib/Horde/Service/Facebook.php | 119 ----- framework/Service_Facebook/lib/Horde/Service/Facebook/Users.php | 166 +++++++ framework/Service_Facebook/package.xml | 12 +- 3 files changed, 173 insertions(+), 124 deletions(-) create mode 100644 framework/Service_Facebook/lib/Horde/Service/Facebook/Users.php http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook.php?rt=horde-hatchery&r1=3d771753c4b857b9c765422991b4d4ac066439ff&r2=5f6106ecdf8b0d5e9a79384be526b8a66d7d714b http://git.horde.org/co.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Users.php?rt=horde-hatchery&r=5f6106ecdf8b0d5e9a79384be526b8a66d7d714b http://git.horde.org/diff.php/framework/Service_Facebook/package.xml?rt=horde-hatchery&r1=ddbc37266f5270df7f95f91710eacadb774e6d0a&r2=5f6106ecdf8b0d5e9a79384be526b8a66d7d714b ----------------------------------------------------------------------- commit acfc756bad1b79402618524c6c064d1e12012321 Author: Michael J. Rubinsky <[email protected]> Date: Wed Feb 25 14:12:17 2009 -0500 Can't cache the session_key in the method classes, since we may set a new session_key after we instantiate one of the classes. framework/Service_Facebook/lib/Horde/Service/Facebook/Base.php | 1 - framework/Service_Facebook/lib/Horde/Service/Facebook/Events.php | 12 +- framework/Service_Facebook/lib/Horde/Service/Facebook/Fql.php | 2 +- framework/Service_Facebook/lib/Horde/Service/Facebook/Friends.php | 10 +- .../Service_Facebook/lib/Horde/Service/Facebook/Notifications.php | 4 +- framework/Service_Facebook/lib/Horde/Service/Facebook/Users.php | 22 ++-- 6 files changed, 25 insertions(+), 26 deletions(-) http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Base.php?rt=horde-hatchery&r1=3d771753c4b857b9c765422991b4d4ac066439ff&r2=acfc756bad1b79402618524c6c064d1e12012321 http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Events.php?rt=horde-hatchery&r1=8579a9e568826b28987468db74fb979beb3fe03a&r2=acfc756bad1b79402618524c6c064d1e12012321 http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Fql.php?rt=horde-hatchery&r1=9bb7f5c5832167ffe463a9823a8ae4c7ebf9bd86&r2=acfc756bad1b79402618524c6c064d1e12012321 http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Friends.php?rt=horde-hatchery&r1=4a037558cec4614b9a5a36f1bbb80e4241ddd0ef&r2=acfc756bad1b79402618524c6c064d1e12012321 http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Notifications.php?rt=horde-hatchery&r1=4a037558cec4614b9a5a36f1bbb80e4241ddd0ef&r2=acfc756bad1b79402618524c6c064d1e12012321 http://git.horde.org/diff.php/framework/Service_Facebook/lib/Horde/Service/Facebook/Users.php?rt=horde-hatchery&r1=5f6106ecdf8b0d5e9a79384be526b8a66d7d714b&r2=acfc756bad1b79402618524c6c064d1e12012321 __ commits mailing list Frequently Asked Questions: http://horde.org/faq/ To unsubscribe, mail: [email protected]
