The branch "H4-Group" has been updated. The following is a summary of the commits.
from: 02f65ef11062e0aa31ae30b51e01e39dc61386a8 2242ab6 Skip tear down if not configured. 78bb7ec Renaming is not supported. 0e27344 Move test into correct place. We don't need a looger. 235bf52 Add a failing test for SQLite driver breaking table when changing the primary key column. e4c5040 There is no 'id' option, there is only a 'primaryKey' option that defaults to 'id'. Fixes first bug. b647b3b Style f935a09 Horde_Db_Adapter_Base_TableDefinition::primaryKey() expects columns, not the complete index object. Fixed the final bug. 59b6aab One more failing test. Adding autoincrementing still not working with SQLite. 71d2ce9 Drop parents column. ----------------------------------------------------------------------- commit 2242ab6507700482601fd2eda5ce53c7f34dfbfd Author: Jan Schneider <[email protected]> Date: Thu Mar 3 22:04:09 2011 +0100 Skip tear down if not configured. framework/Group/test/Horde/Group/LdapTest.php | 18 ++++++++++-------- 1 files changed, 10 insertions(+), 8 deletions(-) http://git.horde.org/horde-git/-/commit/2242ab6507700482601fd2eda5ce53c7f34dfbfd ----------------------------------------------------------------------- commit 78bb7ecc52fd8cd45a0d6558b86fdac9aacfd601 Author: Jan Schneider <[email protected]> Date: Thu Mar 3 22:08:35 2011 +0100 Renaming is not supported. framework/Group/lib/Horde/Group/Ldap.php | 16 +--------------- 1 files changed, 1 insertions(+), 15 deletions(-) http://git.horde.org/horde-git/-/commit/78bb7ecc52fd8cd45a0d6558b86fdac9aacfd601 ----------------------------------------------------------------------- commit 0e273447c713524400bd5be8993775f636db9656 Author: Jan Schneider <[email protected]> Date: Thu Mar 3 22:27:31 2011 +0100 Move test into correct place. We don't need a looger. framework/Db/test/Horde/Db/Migration/BaseTest.php | 10 +++++ framework/Db/test/Horde/Db/Migration/MigratorTest.php | 30 +++++------------ 2 files changed, 19 insertions(+), 21 deletions(-) http://git.horde.org/horde-git/-/commit/0e273447c713524400bd5be8993775f636db9656 ----------------------------------------------------------------------- commit 235bf5239a9755996efe64215ac31410ae05ae09 Author: Jan Schneider <[email protected]> Date: Thu Mar 3 22:35:43 2011 +0100 Add a failing test for SQLite driver breaking table when changing the primary key column. framework/Db/test/Horde/Db/Migration/BaseTest.php | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) http://git.horde.org/horde-git/-/commit/235bf5239a9755996efe64215ac31410ae05ae09 ----------------------------------------------------------------------- commit e4c5040a3bec75804e04e9d17f11cb6019a7f0d4 Author: Jan Schneider <[email protected]> Date: Thu Mar 3 22:57:30 2011 +0100 There is no 'id' option, there is only a 'primaryKey' option that defaults to 'id'. Fixes first bug. framework/Db/lib/Horde/Db/Adapter/Base/Schema.php | 73 ++--- framework/Db/lib/Horde/Db/Adapter/Sqlite/Schema.php | 2 +- .../test/Horde/Db/fixtures/migrations/3_innocent_jointable1.php | 2 +- .../fixtures/migrations_with_duplicate/3_innocent_jointable2.php | 2 +- .../migrations_with_missing_versions/4_innocent_jointable3.php | 2 +- 5 files changed, 39 insertions(+), 42 deletions(-) http://git.horde.org/horde-git/-/commit/e4c5040a3bec75804e04e9d17f11cb6019a7f0d4 ----------------------------------------------------------------------- commit b647b3bb4d7f8fd4febfc803075327bfc491485c Author: Jan Schneider <[email protected]> Date: Thu Mar 3 23:11:12 2011 +0100 Style framework/Db/lib/Horde/Db/Adapter/Base/TableDefinition.php | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) http://git.horde.org/horde-git/-/commit/b647b3bb4d7f8fd4febfc803075327bfc491485c ----------------------------------------------------------------------- commit f935a094a3dd786ed03fadec6c79b74e4b9723eb Author: Jan Schneider <[email protected]> Date: Thu Mar 3 23:12:03 2011 +0100 Horde_Db_Adapter_Base_TableDefinition::primaryKey() expects columns, not the complete index object. Fixed the final bug. framework/Db/lib/Horde/Db/Adapter/Sqlite/Schema.php | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) http://git.horde.org/horde-git/-/commit/f935a094a3dd786ed03fadec6c79b74e4b9723eb ----------------------------------------------------------------------- commit 59b6aab170d13bcd45c4390ea0ef7ca5b5591357 Author: Jan Schneider <[email protected]> Date: Thu Mar 3 23:41:33 2011 +0100 One more failing test. Adding autoincrementing still not working with SQLite. framework/Db/test/Horde/Db/Migration/BaseTest.php | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) http://git.horde.org/horde-git/-/commit/59b6aab170d13bcd45c4390ea0ef7ca5b5591357 ----------------------------------------------------------------------- commit 71d2ce9952ed519783aa6999a7c0cbc9f1c1fecb Author: Jan Schneider <[email protected]> Date: Thu Mar 3 23:42:03 2011 +0100 Drop parents column. .../migration/Horde_Group/3_horde_group_upgrade_drop_parents.php | 19 +++++ 1 files changed, 19 insertions(+), 0 deletions(-) create mode 100644 framework/Group/migration/Horde_Group/3_horde_group_upgrade_drop_parents.php http://git.horde.org/horde-git/-/commit/71d2ce9952ed519783aa6999a7c0cbc9f1c1fecb __ commits mailing list Frequently Asked Questions: http://horde.org/faq/ To unsubscribe, mail: [email protected]
