The branch "master" has been updated. The following is a summary of the commits.
from: 4adcfd4e4ab5329b7a8327a9975b8d3f8987003d 0131561 Remove impmode code 153f7cb Fix displaying group addresses when preview is collapsed 0533696 Don't attempt to get contacts images for group addresses 6fadff7 Verified that IMP can handle groups in From, Sender, Resent-From, and Resent-Sender 06dec82 Fix expanding a group on the compose page 1408057 Don't double-add group addresses 83f7f8e Fix populating group addresses from server data 7ccf695 Change hashing function back to MD5 59f9f6b Replace fnv1-32 and SHA-1 with MD5 in certain contexts c1049c8 update CODING_STANDARDS 2a8ae58 FNV132/SHA1 -> MD5 8b906a3 FNV1-32/SHA-1 -> MD5 54ebbc8 Allow full address to be copied, including personal/group parts 0e73cf2 No support for adding group to filter ca1e900 [mms] Handle a cache miss by trying to load the class in its new location. bffc3c7 Contacts now added by passing in a mail object a27e016 Released Horde_Autoloader_Cache-2.1.1 64a8fca Development mode for Horde_Autoloader_Cache-2.1.2 Summary: http://github.com/horde/horde/compare/4adcfd4e4ab5329b7a8327a9975b8d3f8987003d...64a8fcace1cd5410e10dc2e6e811fad2ee131aa3 ----------------------------------------------------------------------- commit 0131561ee1f7097dae746f9b95395c0b40e95e42 Author: Michael M Slusarz <[email protected]> Date: Mon Jan 5 19:43:05 2015 -0700 Remove impmode code imp/dynamic.php | 1 - imp/lib/Application.php | 13 ------------- imp/smartmobile.php | 4 +--- 3 files changed, 1 insertions(+), 17 deletions(-) http://github.com/horde/horde/commit/0131561ee1f7097dae746f9b95395c0b40e95e42 ----------------------------------------------------------------------- commit 153f7cb833b9d865ce20a2bd55127237f847c33d Author: Michael M Slusarz <[email protected]> Date: Mon Jan 5 19:58:36 2015 -0700 Fix displaying group addresses when preview is collapsed imp/themes/default/dynamic/mailbox.css | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) http://github.com/horde/horde/commit/153f7cb833b9d865ce20a2bd55127237f847c33d ----------------------------------------------------------------------- commit 053369604557fdf2e3e4b862d526cf3708886253 Author: Michael M Slusarz <[email protected]> Date: Mon Jan 5 19:58:56 2015 -0700 Don't attempt to get contacts images for group addresses imp/js/core.js | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) http://github.com/horde/horde/commit/053369604557fdf2e3e4b862d526cf3708886253 ----------------------------------------------------------------------- commit 6fadff75d7d810bc4244207bae9e883956d48391 Author: Michael M Slusarz <[email protected]> Date: Mon Jan 5 20:00:01 2015 -0700 Verified that IMP can handle groups in From, Sender, Resent-From, and Resent-Sender imp/docs/RFCS | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) http://github.com/horde/horde/commit/6fadff75d7d810bc4244207bae9e883956d48391 ----------------------------------------------------------------------- commit 06dec82e99d740805488deaef290ee863da70339 Author: Michael M Slusarz <[email protected]> Date: Mon Jan 5 20:07:17 2015 -0700 Fix expanding a group on the compose page imp/js/compose.js | 18 +++++++++++------- 1 files changed, 11 insertions(+), 7 deletions(-) http://github.com/horde/horde/commit/06dec82e99d740805488deaef290ee863da70339 ----------------------------------------------------------------------- commit 140805747e2aa0d939c089b9bf40eae60ade50e2 Author: Michael M Slusarz <[email protected]> Date: Mon Jan 5 20:27:30 2015 -0700 Don't double-add group addresses imp/lib/Ajax/Addresses.php | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) http://github.com/horde/horde/commit/140805747e2aa0d939c089b9bf40eae60ade50e2 ----------------------------------------------------------------------- commit 83f7f8e0845bdc742c269792e4d0131043caeb1d Author: Michael M Slusarz <[email protected]> Date: Mon Jan 5 20:51:25 2015 -0700 Fix populating group addresses from server data imp/js/compose.js | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) http://github.com/horde/horde/commit/83f7f8e0845bdc742c269792e4d0131043caeb1d ----------------------------------------------------------------------- commit 7ccf69535bd55cc1d09d946f6ddc87e10abbf88c Author: Michael M Slusarz <[email protected]> Date: Mon Jan 5 20:53:12 2015 -0700 Change hashing function back to MD5 Yes, I'm changing back yet again I've spent some of the last few months working on a project that required extensive investigation into the pros/cons of cryptographic vs. non-cryptographic hashes, collision resistance, and hash size. In short, MD5 remains fine for use for things like unique hashing. FNV is most likely fine, but MD5 is plenty fast for this kind of work. And 32 bits means that a birthday attack/collision becomes much more likely (50% chance of finding one after 77K inputs). SHA1 is overkill, at least for the things we are doing in Horde_Imap_Client. framework/Imap_Client/lib/Horde/Imap/Client/Base.php | 12 ++-------- framework/Imap_Client/lib/Horde/Imap/Client/Fetch/Query.php | 5 +--- framework/Imap_Client/lib/Horde/Imap/Client/Socket/Pop3.php | 2 +- 3 files changed, 5 insertions(+), 14 deletions(-) http://github.com/horde/horde/commit/7ccf69535bd55cc1d09d946f6ddc87e10abbf88c ----------------------------------------------------------------------- commit 59f9f6bac43b1534488987481768f82e04e7836c Author: Michael M Slusarz <[email protected]> Date: Mon Jan 5 21:05:38 2015 -0700 Replace fnv1-32 and SHA-1 with MD5 in certain contexts imp/lib/Compose.php | 3 ++- imp/lib/Contents/View.php | 11 ++++------- imp/lib/Factory/ComposeAtc.php | 5 +---- imp/lib/Flag/Base.php | 5 +---- imp/lib/Flag/User.php | 2 +- 5 files changed, 9 insertions(+), 17 deletions(-) http://github.com/horde/horde/commit/59f9f6bac43b1534488987481768f82e04e7836c ----------------------------------------------------------------------- commit c1049c8b843938ece6244df4c7a4874598fee04c Author: Michael M Slusarz <[email protected]> Date: Mon Jan 5 21:10:41 2015 -0700 update CODING_STANDARDS horde/docs/CODING_STANDARDS | 15 ++++----------- 1 files changed, 4 insertions(+), 11 deletions(-) http://github.com/horde/horde/commit/c1049c8b843938ece6244df4c7a4874598fee04c ----------------------------------------------------------------------- commit 2a8ae58825932fc9daf606a816490bb54f910327 Author: Michael M Slusarz <[email protected]> Date: Mon Jan 5 21:24:35 2015 -0700 FNV132/SHA1 -> MD5 framework/Autoloader_Cache/lib/Horde/Autoloader/Cache.php | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) http://github.com/horde/horde/commit/2a8ae58825932fc9daf606a816490bb54f910327 ----------------------------------------------------------------------- commit 8b906a33ef1a3d1b00d121eb5b1684b819e76442 Author: Michael M Slusarz <[email protected]> Date: Mon Jan 5 21:33:22 2015 -0700 FNV1-32/SHA-1 -> MD5 framework/Core/lib/Horde/Core/Factory/BlockCollection.php | 5 +---- framework/Core/lib/Horde/Core/Factory/Db.php | 5 +---- framework/Core/lib/Horde/Core/Factory/Ldap.php | 5 +---- framework/Core/lib/Horde/Core/Factory/Nosql.php | 5 +---- framework/Core/lib/Horde/Core/Factory/Prefs.php | 5 +---- framework/Core/lib/Horde/Core/Notification/Event/Status.php | 5 +---- framework/Core/lib/Horde/Core/Topbar.php | 5 +---- framework/Core/lib/Horde/Registry.php | 2 +- framework/Core/lib/Horde/Script/File.php | 4 ++-- framework/Core/lib/Horde/Script/File/External.php | 5 +---- framework/Core/lib/Horde/Themes/Css/Cache/Null.php | 2 +- 11 files changed, 12 insertions(+), 36 deletions(-) http://github.com/horde/horde/commit/8b906a33ef1a3d1b00d121eb5b1684b819e76442 ----------------------------------------------------------------------- commit 54ebbc8542f559bbb77c2be681bfe1ddaabc5dcb Author: Michael M Slusarz <[email protected]> Date: Mon Jan 5 22:38:36 2015 -0700 Allow full address to be copied, including personal/group parts imp/js/core.js | 2 +- imp/lib/Ajax/Addresses.php | 3 +++ imp/lib/Ajax/Application/ShowMessage.php | 1 + 3 files changed, 5 insertions(+), 1 deletions(-) http://github.com/horde/horde/commit/54ebbc8542f559bbb77c2be681bfe1ddaabc5dcb ----------------------------------------------------------------------- commit 0e73cf28ca1bb10d0f2f3d8f0a14a4510c07c9c0 Author: Michael M Slusarz <[email protected]> Date: Mon Jan 5 22:42:06 2015 -0700 No support for adding group to filter imp/js/core.js | 10 +++++++++- 1 files changed, 9 insertions(+), 1 deletions(-) http://github.com/horde/horde/commit/0e73cf28ca1bb10d0f2f3d8f0a14a4510c07c9c0 ----------------------------------------------------------------------- commit ca1e9002be9ccdf91d33393645bf945ea24e418c Author: Michael M Slusarz <[email protected]> Date: Mon Jan 5 22:52:56 2015 -0700 [mms] Handle a cache miss by trying to load the class in its new location. framework/Autoloader_Cache/lib/Horde/Autoloader/Cache.php | 19 +++++++++++++ framework/Autoloader_Cache/package.xml | 4 +- 2 files changed, 21 insertions(+), 2 deletions(-) http://github.com/horde/horde/commit/ca1e9002be9ccdf91d33393645bf945ea24e418c ----------------------------------------------------------------------- commit bffc3c77ceda302e97a2810fa18e68a864759ee4 Author: Michael M Slusarz <[email protected]> Date: Mon Jan 5 23:42:36 2015 -0700 Contacts now added by passing in a mail object imp/lib/Ajax/Application/Handler/Dynamic.php | 32 +++++++++++++------------ imp/lib/Basic/Thread.php | 15 ++++++++++- imp/lib/Contacts.php | 21 +++++++++-------- 3 files changed, 41 insertions(+), 27 deletions(-) http://github.com/horde/horde/commit/bffc3c77ceda302e97a2810fa18e68a864759ee4 ----------------------------------------------------------------------- commit a27e016becb224a04b161a19ace22981101439fa Author: Michael M Slusarz <[email protected]> Date: Mon Jan 5 23:57:29 2015 -0700 Released Horde_Autoloader_Cache-2.1.1 framework/Autoloader_Cache/composer.json | 8 ++++---- framework/Autoloader_Cache/package.xml | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) http://github.com/horde/horde/commit/a27e016becb224a04b161a19ace22981101439fa ----------------------------------------------------------------------- commit 64a8fcace1cd5410e10dc2e6e811fad2ee131aa3 Author: Michael M Slusarz <[email protected]> Date: Mon Jan 5 23:57:29 2015 -0700 Development mode for Horde_Autoloader_Cache-2.1.2 framework/Autoloader_Cache/package.xml | 17 +++++++++++++++-- 1 files changed, 15 insertions(+), 2 deletions(-) http://github.com/horde/horde/commit/64a8fcace1cd5410e10dc2e6e811fad2ee131aa3 -- commits mailing list Frequently Asked Questions: http://wiki.horde.org/FAQ To unsubscribe, mail: [email protected]
