3 patches to fix couple bugs found in the new binlog implementation: - Fix an unfortunate missed bug where setting @@binlog_checksum would attempt to rotate the old-style binlog files, which is just completely wrong.
- Fix missing sanity checks on the page size in the binlog file header (MDEV-39582). Reverts an earlier incorrect patch for this bug. - Fix missing sanity checks on the chunk_len in binlog files. Kristian Nielsen (3): MDEV-39604: binlog_checksum should be ignored in new binlog MDEV-39582: mariadb-binlog missing sanity checks for ibb files MDEV-39582: mariadb-binlog missing sanity checks for ibb files client/mysqlbinlog-engine.cc | 26 ++++++++++-------- client/mysqlbinlog-engine.h | 1 + .../corrupt-chunk-len_binlog-000000.ibb | Bin 0 -> 32768 bytes .../corrupt-chunk-len_binlog-000001.ibb | Bin 0 -> 32768 bytes .../binlog_in_engine/binlog_restart.result | 6 ++++ .../binlog_in_engine/binlog_restart.test | 14 ++++++++++ .../suite/binlog_in_engine/mysqlbinlog.result | 8 +++++- .../suite/binlog_in_engine/mysqlbinlog.test | 3 ++ .../not_implemented_yet.result | 14 ++++++++++ .../binlog_in_engine/not_implemented_yet.test | 9 ++++++ sql/log.cc | 16 +++++++---- storage/innobase/fsp/fsp_binlog.cc | 20 ++++++++------ storage/innobase/handler/innodb_binlog.cc | 2 -- 13 files changed, 91 insertions(+), 28 deletions(-) create mode 100644 mysql-test/std_data/corrupt-chunk-len_binlog-000000.ibb create mode 100644 mysql-test/std_data/corrupt-chunk-len_binlog-000001.ibb -- 2.47.3 _______________________________________________ commits mailing list -- [email protected] To unsubscribe send an email to [email protected]
