dacort commented on code in PR #367: URL: https://github.com/apache/incubator-livy/pull/367#discussion_r1043905446
########## .dockerignore: ########## @@ -0,0 +1,3 @@ +# Build output Review Comment: I believe the `target` directories made up the majority of the artifacts getting sent to the docker daemon. When using the updated `.dockerignore`, the build context is much smaller. ``` Sending build context to Docker daemon 7.879MB ``` I'm unsure what typical practices are here. [Many other apache projects](https://cs.github.com/?scopeName=All+repos&scope=&q=org%3Aapache+language%3ADockerfile) seem to place them in subdirs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
