jianzhenwu commented on PR #377: URL: https://github.com/apache/incubator-livy/pull/377#issuecomment-1356997629
> I am not sure about the change, as this does not involve only the thriftserver module, but all interactive sessions. If the problem involves all interactive sessions, then it is ok, otherwise the fix is probably not the correct one. Can you check if the same issue affects all interactive jobs? If so, I think we can go ahead with this PR, but I would recommend a different reviewer more familiar with the code in rsc, otherwise, the fix needs to be done only on the thriftserver part and we need more investigation to understand why normal interactive sessions do not have the issue while thriftserver has. Thanks. The same issue doesn't affect interactive jobs which created by REST API. The is because the handle functions are different in the driver. The REST API uses `handle(ctx: ChannelHandlerContext, msg: BaseProtocol.ReplJobRequest)` in the ReplDriver while thrift API uses `handle(ChannelHandlerContext ctx, JobRequest<?> msg)` in the RSCDRiver. ReplDriver changes state when execute code by invoking stateChangedCallback which broadcast the state to all RPC clients. RSCDriver does not broadcast state to RPC clients. I think this patch would not affect other interactive jobs except using thrift API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
