askhatri commented on code in PR #384:
URL: https://github.com/apache/incubator-livy/pull/384#discussion_r1089635745
##########
server/src/main/scala/org/apache/livy/sessions/SessionManager.scala:
##########
@@ -168,7 +169,9 @@ class SessionManager[S <: Session, R <: RecoveryMetadata :
ClassTag](
false
} else {
val currentTime = System.nanoTime()
- currentTime - session.lastActivity > sessionTimeout
+ val calculatedTimeout =
Review Comment:
nanoseconds logic is only for internal calculation and `System.nanoTime()`
is an existing code. End user has option to provide the value like "30s" for 30
seconds and "2m" for 2 minutes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
