askhatri commented on code in PR #384:
URL: https://github.com/apache/incubator-livy/pull/384#discussion_r1098603641
##########
server/src/main/scala/org/apache/livy/server/interactive/InteractiveSessionServlet.scala:
##########
@@ -52,15 +53,18 @@ class InteractiveSessionServlet(
override protected def createSession(req: HttpServletRequest):
InteractiveSession = {
val createRequest = bodyAs[CreateInteractiveRequest](req)
+ val sessionId = sessionManager.nextId();
+ ClientConf.getTimeAsNanos(createRequest.ttl.orNull, sessionId, 0L);
Review Comment:
I have changed the code by removing 0L and also added comment to avoid the
confusion. We can not parse and set the ttl value during session creation as
ttl field is taking String where as calculated value is in long. If we are a
need field as "calculatedTtlValue" then it will be more complexity and very
default to support session recovery scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
