ashokkumarrathore commented on code in PR #462:
URL: https://github.com/apache/incubator-livy/pull/462#discussion_r1928866408
##########
server/src/main/scala/org/apache/livy/utils/SparkKubernetesApp.scala:
##########
@@ -138,6 +138,7 @@ object SparkKubernetesApp extends Logging {
private var sessionLeakageCheckInterval: Long = _
var kubernetesClient: DefaultKubernetesClient = _
+ var appNamespaces: mutable.Set[String] = mutable.Set("default")
Review Comment:
That's a good point. The challenge would be to when to truncate. One
condition i can think of is, just after deleting all leaked apps. In a rare
case this might still leave some leaked apps(apps which were just added to
leaked list).I will see what other options we have.
I still need to write some unit tests. But before that i want to make sure
existing tests pass. How do i get this workflow approved from maintainer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
